Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1135713004: Fix errors from commit f0a169e. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix errors from commit f0a169e. - fread() returns the number of items read. - fix a memory leak in error handling. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/470408c2ffe71e99cebad0d1d6887f1723f02cef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 7 months ago (2015-05-08 18:30:00 UTC) #2
Tom Sepez
lgtm
5 years, 7 months ago (2015-05-08 18:31:58 UTC) #3
Lei Zhang
5 years, 7 months ago (2015-05-08 18:34:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
470408c2ffe71e99cebad0d1d6887f1723f02cef (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698