Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1133353002: cipd: Skip test on Windows for now. (Closed)

Created:
5 years, 7 months ago by Vadim Sh.
Modified:
5 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

cipd: Skip test on Windows for now. The code compiles, but unit tests don't work because Windows handles symlinks and other file system stuff differently. R=iannucci@chromium.org BUG=487483 Committed: https://chromium.googlesource.com/infra/infra/+/525831118c04806a91726c73c4a4fa179dc16ff3

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M go/src/infra/gae/apps/helloworld/helloworld.infra_testing View 1 1 chunk +1 line, -0 lines 0 comments Download
M go/src/infra/gae/libs/context/context.infra_testing View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/gae/libs/meta/meta.infra_testing View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/libs/auth/internal/internal.infra_testing View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/libs/build/build.infra_testing View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/tools/auth/auth.infra_testing View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/tools/cipd/apps/cipd/cipd.infra_testing View 1 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/tools/cipd/cipd.infra_testing View 1 1 chunk +1 line, -0 lines 0 comments Download
M go/src/infra/tools/cipd/local/local.infra_testing View 1 1 chunk +1 line, -0 lines 0 comments Download
M go/test.py View 1 4 chunks +41 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Vadim Sh.
5 years, 7 months ago (2015-05-13 04:46:50 UTC) #1
iannucci
lgtm, though I would consider the startswith thing, even though it's a bit weird. Being ...
5 years, 7 months ago (2015-05-13 08:18:19 UTC) #2
iannucci
technically... it would be really good if the platform values equaled the GOOS values, since ...
5 years, 7 months ago (2015-05-13 08:18:54 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1133353002/diff/1/go/test.py File go/test.py (right): https://codereview.chromium.org/1133353002/diff/1/go/test.py#newcode92 go/test.py:92: "skip_testing": boolean or a list of platforms to skip ...
5 years, 7 months ago (2015-05-13 22:57:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133353002/20001
5 years, 7 months ago (2015-05-13 22:57:49 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 23:01:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/525831118c04806a91726c73c4a4f...

Powered by Google App Engine
This is Rietveld 408576698