cipd: Skip test on Windows for now.

go/test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Go unit tests verifying code coverage.
 
 Expects Go toolset to be in PATH, GOPATH and GOROOT correctly set. Use ./env.py
 to set them up.
 
@@ skipping 71 matching lines @@
 
 
 _package_info_cache = {}
 
 def get_package_info(package):
   """Returns contents of <package>/<name>.infra_testing file or {} if missing.
 
   *.infra_testing contains a JSON dict with the following keys:
   {
     // Do not run tests in this package at all. Default 'false'.
-    "skip_testing": boolean,
+    "skip_testing": boolean or a list of platforms to skip tests on,

[iannucci, 2015/05/13 08:18:19]

why not always a list of platforms?

[Vadim Sh., 2015/05/13 22:57:24]

Okay...

     // Minimum allowed code coverage percentage, see below. Default '100'.
     "expected_coverage_min": number,
     // Maximum allowed code coverage percentage, see below. Default '100'.
     "expected_coverage_max": number
   }
 
   expected_coverage_min and expected_coverage_max set a boundary on what the
   code coverage percentage of the package is expected to be. test.py will fail
   if code coverage is less than 'expected_coverage_min' (meaning the package
   code has degraded), or larger than 'expected_coverage_max' (meaning the
@@ skipping 30 matching lines @@
       print >> sys.stderr, 'Not a valid JSON file: %s' % info_file
       return {}
 
   if package not in _package_info_cache:
     _package_info_cache[package] = do_read()
   return _package_info_cache[package]
 
 
 def should_skip(package):
   """True to skip package tests, reads 'skip_testing' from *.infra_testing."""
-  return get_package_info(package).get('skip_testing', False)
+  skip = get_package_info(package).get('skip_testing', False)
+  if isinstance(skip, list):
+    return sys.platform in skip

[iannucci, 2015/05/13 08:18:19]

   return sys.platform.startswith(skip)

maybe?

Then "linux" would work. So would [""], actually (to replace 'true'). Or maybe
it's 1:20am and I'm loopy.

[Vadim Sh., 2015/05/13 22:57:24]

[""] is sort of confusing... 

Made it GOOS ("darwin", "linux", "windows").

+  return bool(skip)
+
 
 def get_build_tags(package):
-  """True to skip package tests, reads 'skip_testing' from *.infra_testing."""
+  """Build tags to use when building a package, read from *.infra_testing."""
   tags = get_package_info(package).get('build_tags', ())
   if tags:
     return '-tags='+(','.join(tags))
   return None
 
+
 def get_expected_coverage(package):
   """Returns allowed code coverage percentage as a pair (min, max)."""
   info = get_package_info(package)
   min_cover = info.get('expected_coverage_min', 100.0)
   max_cover = info.get('expected_coverage_max', 100.0)
   if max_cover < min_cover:
     max_cover = min_cover
   return (min_cover, max_cover)
 
 
@@ skipping 88 matching lines @@
     print 'Use ./env.py python test.py'
     return 1
 
   # Coverage dir is always overwritten with new coverage reports.
   if os.path.exists(coverage_dir):
     shutil.rmtree(coverage_dir)
     makedirs(coverage_dir)
 
   # Code coverage report requires tests to be run against a single package, so
   # discover all individual packages.
-  packages = [p for p in list_packages(package_root) if not should_skip(p)]
+  skipped = []
+  packages = []
+  for p in list_packages(package_root):
+    if should_skip(p):
+      skipped.append(p)
+    else:
+      packages.append(p)
+  if skipped:
+    print 'Skipping %d packages' % len(skipped)
   if not packages:
     print 'No tests to run'
     return 0
 
   failed = []
   bad_cover = []
   tpool = ThreadPool(len(packages))
   def run(pkg):
     coverage_file = os.path.join(coverage_dir, pkg.replace('/', os.sep))
     return run_package_tests(pkg, coverage_file)
@@ skipping 57 matching lines @@
   elif len(args) == 1:
     package_root = args[0]
   else:
     print >> sys.stderr, sys.modules['__main__'].__doc__.strip()
     return 1
   return run_tests(package_root, os.path.join(INFRA_GO_DIR, 'coverage'))
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))