Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1133303006: [turbofan] Add FrameStates before all property accesses. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add FrameStates before all property accesses. R=jarin@chromium.org BUG= Committed: https://crrev.com/29e15dad16984ba62d63c72149525c61a4e5328e Cr-Commit-Position: refs/heads/master@{#28392}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -125 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +8 lines, -7 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 27 chunks +92 lines, -52 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 12 chunks +89 lines, -47 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 7 months ago (2015-05-13 11:20:31 UTC) #1
titzer
https://codereview.chromium.org/1133303006/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/1133303006/diff/1/src/compiler/js-generic-lowering.cc#newcode222 src/compiler/js-generic-lowering.cc:222: #if 0 && DEBUG BTW I need to fix ...
5 years, 7 months ago (2015-05-13 11:22:48 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-13 11:44:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133303006/20001
5 years, 7 months ago (2015-05-13 12:27:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 12:29:43 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 12:29:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29e15dad16984ba62d63c72149525c61a4e5328e
Cr-Commit-Position: refs/heads/master@{#28392}

Powered by Google App Engine
This is Rietveld 408576698