Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: test/unittests/compiler/js-type-feedback-unittest.cc

Issue 1133303006: [turbofan] Add FrameStates before all property accesses. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/operator-properties.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-type-feedback-unittest.cc
diff --git a/test/unittests/compiler/js-type-feedback-unittest.cc b/test/unittests/compiler/js-type-feedback-unittest.cc
index 08fe68a8baa037141046ab748394342c131c1540..46eb437b8c488fca2dc4671d16f8dd3e02df0682 100644
--- a/test/unittests/compiler/js-type-feedback-unittest.cc
+++ b/test/unittests/compiler/js-type-feedback-unittest.cc
@@ -80,10 +80,13 @@ class JSTypeFeedbackTest : public TypedGraphTest {
Unique<Name> name = Unique<Name>::CreateUninitialized(
isolate()->factory()->NewStringFromAsciiChecked(string));
- Node* load = graph()->NewNode(javascript()->LoadNamed(name, feedback),
- global, context);
+ const Operator* op = javascript()->LoadNamed(name, feedback);
+ Node* load = graph()->NewNode(op, global, context);
if (FLAG_turbo_deoptimization) {
- load->AppendInput(zone(), EmptyFrameState());
+ for (int i = 0; i < OperatorProperties::GetFrameStateInputCount(op);
+ i++) {
+ load->AppendInput(zone(), EmptyFrameState());
+ }
}
load->AppendInput(zone(), effect);
load->AppendInput(zone(), control);
« no previous file with comments | « src/compiler/operator-properties.cc ('k') | test/unittests/compiler/js-typed-lowering-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698