Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1133303004: Fix and enable ExtensionApiTest.ExtensionFullscreenAccessPass (no mac). (Closed)

Created:
5 years, 7 months ago by lazyboy
Modified:
5 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and enable ExtensionApiTest.ExtensionFullscreenAccessPass (no mac). Add user gesture when calling requestFullscreen(). The test doesn't pass on mac bots, related to other FullScreen test failures on mac. BUG=174178 Test=None, internal test change. Committed: https://crrev.com/80f69ca9b991b71adb8c13d759195722b080e0a1 Cr-Commit-Position: refs/heads/master@{#330134}

Patch Set 1 #

Patch Set 2 : with cancel x 500 #

Patch Set 3 : remove mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/extensions/extension_fullscreen_apitest.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/fullscreen/has_permission/window.js View 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
lazyboy
+Vincent for review. I'm trying to make fullscreen tests pass on mac bots, but cannot ...
5 years, 7 months ago (2015-05-15 06:27:57 UTC) #2
scheib
LGTM
5 years, 7 months ago (2015-05-15 18:04:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133303004/40001
5 years, 7 months ago (2015-05-15 18:06:45 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 18:13:57 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:15:15 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/80f69ca9b991b71adb8c13d759195722b080e0a1
Cr-Commit-Position: refs/heads/master@{#330134}

Powered by Google App Engine
This is Rietveld 408576698