Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/browser/extensions/extension_fullscreen_apitest.cc

Issue 1133303004: Fix and enable ExtensionApiTest.ExtensionFullscreenAccessPass (no mac). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove mac Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/fullscreen/has_permission/window.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_fullscreen_apitest.cc
diff --git a/chrome/browser/extensions/extension_fullscreen_apitest.cc b/chrome/browser/extensions/extension_fullscreen_apitest.cc
index 9abe3c333dec4866c7f96458c07e69b287489ebe..198fd71fba0af4dc0b9f00707a006e5ef950d05d 100644
--- a/chrome/browser/extensions/extension_fullscreen_apitest.cc
+++ b/chrome/browser/extensions/extension_fullscreen_apitest.cc
@@ -7,13 +7,19 @@
IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
ExtensionFullscreenAccessFail) {
- // Test that fullscreen can be accessed from an extension without permission.
+ // Test that fullscreen cannot be accessed from an extension without
+ // permission.
ASSERT_TRUE(RunPlatformAppTest("fullscreen/no_permission")) << message_;
}
-// Disabled, a user gesture is required for fullscreen. http://crbug.com/174178
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
- DISABLED_ExtensionFullscreenAccessPass) {
+#if defined(OS_MACOSX)
+// Fails on MAC: http://crbug.com/480370
+#define MAYBE_ExtensionFullscreenAccessPass \
+ DISABLED_ExtensionFullscreenAccessPass
+#else
+#define MAYBE_ExtensionFullscreenAccessPass ExtensionFullscreenAccessPass
+#endif // defined(OS_MACOSX)
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_ExtensionFullscreenAccessPass) {
// Test that fullscreen can be accessed from an extension with permission.
ASSERT_TRUE(RunPlatformAppTest("fullscreen/has_permission")) << message_;
}
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/fullscreen/has_permission/window.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698