Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 1133303003: Add support for crypto::ECPrivateKey::Copy when built with BoringSSL (Closed)

Created:
5 years, 7 months ago by nharper
Modified:
5 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for crypto::ECPrivateKey::Copy when built with BoringSSL BUG=457566 Committed: https://crrev.com/e6bf56c073dcb15017f4985d75991dc176b8dda1 Cr-Commit-Position: refs/heads/master@{#329527}

Patch Set 1 #

Patch Set 2 : EVP_PKEY_dup -> EVP_PKEY_up_ref #

Total comments: 2

Patch Set 3 : switch back to dup; remove unnecessary check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M crypto/ec_private_key.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/ec_private_key_openssl.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M crypto/ec_private_key_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nharper
5 years, 7 months ago (2015-05-12 21:45:42 UTC) #2
davidben
lgtm https://codereview.chromium.org/1133303003/diff/20001/crypto/ec_private_key_openssl.cc File crypto/ec_private_key_openssl.cc (right): https://codereview.chromium.org/1133303003/diff/20001/crypto/ec_private_key_openssl.cc#newcode93 crypto/ec_private_key_openssl.cc:93: return NULL; You can drop these two lines. ...
5 years, 7 months ago (2015-05-12 21:55:07 UTC) #3
nharper
https://codereview.chromium.org/1133303003/diff/20001/crypto/ec_private_key_openssl.cc File crypto/ec_private_key_openssl.cc (right): https://codereview.chromium.org/1133303003/diff/20001/crypto/ec_private_key_openssl.cc#newcode93 crypto/ec_private_key_openssl.cc:93: return NULL; On 2015/05/12 21:55:06, David Benjamin wrote: > ...
5 years, 7 months ago (2015-05-12 22:07:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133303003/40001
5 years, 7 months ago (2015-05-12 22:07:44 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 23:09:05 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 23:09:58 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e6bf56c073dcb15017f4985d75991dc176b8dda1
Cr-Commit-Position: refs/heads/master@{#329527}

Powered by Google App Engine
This is Rietveld 408576698