Add support for crypto::ECPrivateKey::Copy when built with BoringSSL

crypto/ec_private_key_openssl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "crypto/ec_private_key.h"
 
 #include <openssl/ec.h>
 #include <openssl/evp.h>
 #include <openssl/pkcs12.h>
 #include <openssl/x509.h>
@@ skipping 67 matching lines @@
   return true;
 }
 
 }  // namespace
 
 ECPrivateKey::~ECPrivateKey() {
   if (key_)
     EVP_PKEY_free(key_);
 }
 
+ECPrivateKey* ECPrivateKey::Copy() const {
+  scoped_ptr<ECPrivateKey> copy(new ECPrivateKey);
+  if (key_) {
+    copy->key_ = EVP_PKEY_up_ref(key_);
+    if (!copy->key_)
+      return NULL;

[davidben, 2015/05/12 21:55:06]

You can drop these two lines. EVP_PKEY_up_ref can't fail, even with malloc
failures.

[nharper, 2015/05/12 22:07:29]

Done.

+  }
+  return copy.release();
+}
+
 // static
 bool ECPrivateKey::IsSupported() { return true; }
 
 // static
 ECPrivateKey* ECPrivateKey::Create() {
   OpenSSLErrStackTracer err_tracer(FROM_HERE);
 
   ScopedEC_KEY ec_key(EC_KEY_new_by_curve_name(NID_X9_62_prime256v1));
   if (!ec_key.get() || !EC_KEY_generate_key(ec_key.get()))
     return NULL;
@@ skipping 124 matching lines @@
   OpenSSLErrStackTracer err_tracer(FROM_HERE);
   ScopedEC_KEY ec_key(EVP_PKEY_get1_EC_KEY(key_));
   return ExportKey(ec_key.get(),
                    reinterpret_cast<ExportDataFunction>(i2d_ECParameters),
                    output);
 }
 
 ECPrivateKey::ECPrivateKey() : key_(NULL) {}
 
 }  // namespace crypto