Issue 1133283006: [PermissionBubble] Handle ownership management x-platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133283006: [PermissionBubble] Handle ownership management x-platform.

Created:
5 years, 7 months ago by groby-ooo-7-16

Modified:
5 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, tfarina, markusheintz, hcarmona

Base URL:
https://chromium.googlesource.com/chromium/src.git@argfix

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[PermissionBubble] Handle ownership management x-platform. This migrates ownership handling for the permission bubble to the cross-platform layer, since it already worked in a platform-independent way. BUG=none

Patch Set 1 #

Patch Set 2 : And remove the platform-specific stuff. #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -38 lines)			Patch
M	chrome/browser/ui/browser.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		3 chunks	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.h	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1	2 chunks	+0 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/views/website_settings/permissions_bubble_view.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_view.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

groby-ooo-7-16

5 years, 7 months ago (2015-05-15 22:55:21 UTC) #2

Just as an FYI for now - this is where the refactor for the bubbles is
ultimately heading. This is very much a WIP, so please don't review just yet. 

But it's giving you an idea of the final plan :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages