Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1133283006: [PermissionBubble] Handle ownership management x-platform. Base URL: https://chromium.googlesource.com/chromium/src.git@argfix
Patch Set: And remove the platform-specific stuff. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 89365884465f36be36c9ddc76ca99de2d07da536..285f2886f42ec70fb178406900f5bebf6aad331b 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -866,17 +866,6 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,
infobar_container_->ChangeInfoBarManager(
InfoBarService::FromWebContents(new_contents));
- if (old_contents && PermissionBubbleManager::FromWebContents(old_contents))
- PermissionBubbleManager::FromWebContents(old_contents)->SetView(nullptr);
-
- if (new_contents && PermissionBubbleManager::FromWebContents(new_contents)) {
- if (!permission_bubble_.get())
- permission_bubble_.reset(new PermissionBubbleViewViews(browser_.get()));
-
- PermissionBubbleManager::FromWebContents(new_contents)->SetView(
- permission_bubble_.get());
- }
-
UpdateUIForContents(new_contents);
// Layout for DevTools _before_ setting the both main and devtools WebContents

Powered by Google App Engine
This is Rietveld 408576698