chrome/browser/push_messaging/push_messaging_service_impl.h - Issue 1133083002: Reject the permissionState promise with NotSupported Exception (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 1133083002: Reject the permissionState promise with NotSupported Exception (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | content/child/push_messaging/push_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_service_impl.h

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.h b/chrome/browser/push_messaging/push_messaging_service_impl.h

index 4919c0fd4e79f9ca6dc6f6810bf6d22af6cae873..27001da91f201157a112559d018553f4569455ba 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.h

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.h

@@ -86,6 +86,8 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

const GURL& requesting_origin,

const GURL& embedding_origin,

bool user_visible) override;

+ bool SupportNonVisibleMessages() override;

// content_settings::Observer implementation.

void OnContentSettingChanged(const ContentSettingsPattern& primary_pattern,