chrome/browser/push_messaging/push_messaging_service_impl.cc - Issue 1133083002: Reject the permissionState promise with NotSupported Exception (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.cc

Issue 1133083002: Reject the permissionState promise with NotSupported Exception (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.h ('k') | content/browser/push_messaging/push_messaging_message_filter.cc » ('j') | content/child/push_messaging/push_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_service_impl.cc

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc

index 2cf40858917e02826c24099f8695173a538e50d0..6cf3e2797179c79393dc31edab17f38e41ab7339 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc

@@ -406,6 +406,10 @@ blink::WebPushPermissionStatus PushMessagingServiceImpl::GetPermissionStatus(

requesting_origin, embedding_origin));

}

+bool PushMessagingServiceImpl::SupportNonVisibleMessages() {

+ return false;

void PushMessagingServiceImpl::RegisterEnd(

const content::PushMessagingService::RegisterCallback& callback,

const std::string& registration_id,