Reject the permissionState promise with NotSupported Exception (2/3)

content/public/browser/push_messaging_service.h

Index: content/public/browser/push_messaging_service.h
diff --git a/content/public/browser/push_messaging_service.h b/content/public/browser/push_messaging_service.h
index c1a6f1cb6a03247deb1bf5a6d9e4ddf34771ddac..0010bb97d13be91033161827109c669dc1e0560b 100644
--- a/content/public/browser/push_messaging_service.h
+++ b/content/public/browser/push_messaging_service.h
@@ -77,6 +77,9 @@ class CONTENT_EXPORT PushMessagingService {
       const GURL& embedding_origin,
       bool user_visible) = 0;
 
+  // Returns true if silent push messages are accepted

[Peter Beverloo, 2015/05/11 12:56:07]

Punctuation - it's a sentence. Also, "true" is implied since it's a boolean, and
"silent" in the comment vs. "non visible" in the method name may not be obvious
for the occasional reader.

What about:

  // Returns whether subscriptions that do not mandate user visible UI upon
  // receiving a push message are supported. Influences permission request and
  // permission check behaviour.

[Miguel Garcia, 2015/05/11 13:50:38]

Done.

+  virtual bool SupportNonVisibleMessages();

[Peter Beverloo, 2015/05/11 12:56:07]

nit: This should be pure virtual, like the rest of the non-static API.

The overrides should be added in:
 - /chrome/browser/push_messaging/push_messaging_service_impl.h
 - /content/shell/browser/layout_test/layout_test_push_messaging_service.h

[Miguel Garcia, 2015/05/11 13:50:38]

Done.

+
  protected:
   // Provide a storage mechanism to read/write an opaque
   // "notifications_shown_by_last_few_pushes" string associated with a Service