Reject the permissionState promise with NotSupported Exception (2/3)

content/public/browser/push_messaging_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_PUSH_MESSAGING_SERVICE_H_
 #define CONTENT_PUBLIC_BROWSER_PUSH_MESSAGING_SERVICE_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
@@ skipping 59 matching lines @@
 
   // Checks the permission status for the requesting origin. Permission is only
   // ever granted when the requesting origin matches the top level embedding
   // origin. The |user_visible| boolean indicates whether the permission status
   // only has to cover push messages resulting in visible effects to the user.
   virtual blink::WebPushPermissionStatus GetPermissionStatus(
       const GURL& requesting_origin,
       const GURL& embedding_origin,
       bool user_visible) = 0;
 
+  // Returns true if silent push messages are accepted

[Peter Beverloo, 2015/05/11 12:56:07]

Punctuation - it's a sentence. Also, "true" is implied since it's a boolean, and
"silent" in the comment vs. "non visible" in the method name may not be obvious
for the occasional reader.

What about:

  // Returns whether subscriptions that do not mandate user visible UI upon
  // receiving a push message are supported. Influences permission request and
  // permission check behaviour.

[Miguel Garcia, 2015/05/11 13:50:38]

Done.

+  virtual bool SupportNonVisibleMessages();

[Peter Beverloo, 2015/05/11 12:56:07]

nit: This should be pure virtual, like the rest of the non-static API.

The overrides should be added in:
 - /chrome/browser/push_messaging/push_messaging_service_impl.h
 - /content/shell/browser/layout_test/layout_test_push_messaging_service.h

[Miguel Garcia, 2015/05/11 13:50:38]

Done.

+
  protected:
   // Provide a storage mechanism to read/write an opaque
   // "notifications_shown_by_last_few_pushes" string associated with a Service
   // Worker registration. Stored data is deleted when the associated
   // registration is deleted.
   static void GetNotificationsShownByLastFewPushes(
       ServiceWorkerContext* service_worker_context,
       int64 service_worker_registration_id,
       const StringCallback& callback);
   static void SetNotificationsShownByLastFewPushes(
@@ skipping 12 matching lines @@
   // |service_worker_registration_id| for the given |origin|.
   static void ClearPushRegistrationID(BrowserContext* browser_context,
                                       const GURL& origin,
                                       int64 service_worker_registration_id,
                                       const base::Closure& callback);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_PUSH_MESSAGING_SERVICE_H_