Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add new path for createMediaPlayer() Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index aa7b07333d6e2dee4e05ae0c6a5ebb5a17bc214c..de5a31dd166a389bcc75df2495f96b1a1a71929e 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -38,6 +38,7 @@
#include "media/filters/chunk_demuxer.h"
#include "media/filters/ffmpeg_demuxer.h"
#include "third_party/WebKit/public/platform/WebEncryptedMediaTypes.h"
+#include "third_party/WebKit/public/platform/WebMediaPlayerClient.h"
#include "third_party/WebKit/public/platform/WebMediaSource.h"
#include "third_party/WebKit/public/platform/WebRect.h"
#include "third_party/WebKit/public/platform/WebSize.h"
@@ -103,6 +104,7 @@ STATIC_ASSERT_MATCHING_ENUM(UseCredentials);
WebMediaPlayerImpl::WebMediaPlayerImpl(
blink::WebLocalFrame* frame,
blink::WebMediaPlayerClient* client,
+ blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,
base::WeakPtr<WebMediaPlayerDelegate> delegate,
scoped_ptr<RendererFactory> renderer_factory,
CdmFactory* cdm_factory,
@@ -124,6 +126,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
pending_seek_(false),
should_notify_time_changed_(false),
client_(client),
+ encrypted_client_(encrypted_client),
delegate_(delegate),
defer_load_cb_(params.defer_load_cb()),
context_3d_cb_(params.context_3d_cb()),
@@ -139,7 +142,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
BIND_TO_RENDER_LOOP(&WebMediaPlayerImpl::OnNaturalSizeChanged),
BIND_TO_RENDER_LOOP(&WebMediaPlayerImpl::OnOpacityChanged))),
encrypted_media_support_(cdm_factory,
- client,
+ encrypted_client,
params.media_permission(),
base::Bind(&WebMediaPlayerImpl::SetCdm,
AsWeakPtr(),
@@ -704,18 +707,18 @@ void WebMediaPlayerImpl::OnEncryptedMediaInitData(
encrypted_media_support_.SetInitDataType(init_data_type);
- client_->encrypted(ConvertToWebInitDataType(init_data_type),
- vector_as_array(&init_data),
- base::saturated_cast<unsigned int>(init_data.size()));
+ encrypted_client_->encrypted(
ddorwin 2015/07/10 17:56:56 Must #include the definition
Srirama 2015/07/10 18:36:03 Please refer to my comment in webmediaplayer_andro
Srirama 2015/07/11 08:44:10 Done.
+ ConvertToWebInitDataType(init_data_type), vector_as_array(&init_data),
+ base::saturated_cast<unsigned int>(init_data.size()));
}
void WebMediaPlayerImpl::OnWaitingForDecryptionKey() {
- client_->didBlockPlaybackWaitingForKey();
+ encrypted_client_->didBlockPlaybackWaitingForKey();
// TODO(jrummell): didResumePlaybackBlockedForKey() should only be called
// when a key has been successfully added (e.g. OnSessionKeysChange() with
// |has_additional_usable_key| = true). http://crbug.com/461903
- client_->didResumePlaybackBlockedForKey();
+ encrypted_client_->didResumePlaybackBlockedForKey();
}
void WebMediaPlayerImpl::SetCdm(const CdmAttachedCB& cdm_attached_cb,

Powered by Google App Engine
This is Rietveld 408576698