Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 1133033003: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add new path for createMediaPlayer() Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 7611220675f3197fdb23a5486b01927c415116a0..6101007740f20085c4a647a9ee7254470a97670e 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -28,13 +28,14 @@
#include "media/blink/webmediaplayer_util.h"
#include "third_party/WebKit/public/platform/WebAudioSourceProvider.h"
#include "third_party/WebKit/public/platform/WebContentDecryptionModuleResult.h"
-#include "third_party/WebKit/public/platform/WebMediaPlayer.h"
-#include "third_party/WebKit/public/platform/WebMediaPlayerClient.h"
#include "url/gurl.h"
namespace blink {
class WebGraphicsContext3D;
class WebLocalFrame;
+class WebMediaPlayer;
ddorwin 2015/07/10 17:56:56 This is a base class and must be #included.
Srirama 2015/07/10 18:36:03 Acknowledged.
Srirama 2015/07/11 08:44:10 Done.
+class WebMediaPlayerClient;
+class WebMediaPlayerEncryptedMediaClient;
}
namespace base {
@@ -68,12 +69,14 @@ class MEDIA_EXPORT WebMediaPlayerImpl
// internal renderer will be created.
// TODO(xhwang): Drop the internal renderer path and always pass in a renderer
// here.
- WebMediaPlayerImpl(blink::WebLocalFrame* frame,
- blink::WebMediaPlayerClient* client,
- base::WeakPtr<WebMediaPlayerDelegate> delegate,
- scoped_ptr<RendererFactory> renderer_factory,
- CdmFactory* cdm_factory,
- const WebMediaPlayerParams& params);
+ WebMediaPlayerImpl(
+ blink::WebLocalFrame* frame,
+ blink::WebMediaPlayerClient* client,
+ blink::WebMediaPlayerEncryptedMediaClient* encrypted_client,
+ base::WeakPtr<WebMediaPlayerDelegate> delegate,
+ scoped_ptr<RendererFactory> renderer_factory,
+ CdmFactory* cdm_factory,
+ const WebMediaPlayerParams& params);
virtual ~WebMediaPlayerImpl();
virtual void load(LoadType load_type,
@@ -289,6 +292,7 @@ class MEDIA_EXPORT WebMediaPlayerImpl
bool should_notify_time_changed_;
blink::WebMediaPlayerClient* client_;
+ blink::WebMediaPlayerEncryptedMediaClient* encrypted_client_;
base::WeakPtr<WebMediaPlayerDelegate> delegate_;

Powered by Google App Engine
This is Rietveld 408576698