Update GetTexParameter* and TexParameter* for ES3 in GPU command buffer

Update GetTexParameter* and TexParameter* for ES3 in GPU command buffer

Support more kinds of `pname` for these two interfaces.

BUG=429053
Committed: https://crrev.com/98291957a952d2fa956f760423425e4f9ce7a96f
Cr-Commit-Position: refs/heads/master@{#329367}

[legend, 2015-05-11 07:07:38]

guanxian.li@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[legend, 2015-05-11 07:17:14]

PTAL if have times. Thanks!

https://codereview.chromium.org/1133033002/diff/1/gpu/blink/webgraphicscontex...
File gpu/blink/webgraphicscontext3d_impl.cc (left):

https://codereview.chromium.org/1133033002/diff/1/gpu/blink/webgraphicscontex...
gpu/blink/webgraphicscontext3d_impl.cc:646: // TODO(kbr): figure out whether the
setting of TEXTURE_WRAP_R in
@kbr and others, i'm not sure if this comment and related code could be removed
for supporting TEXTURE_WRAP_R.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/common/g...
File gpu/command_buffer/common/gles2_cmd_utils.cc (left):

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/common/g...
gpu/command_buffer/common/gles2_cmd_utils.cc:206: case
GL_TEXTURE_IMMUTABLE_FORMAT_EXT:
Remove this because it is duplicate with GL_TEXTURE_IMMUTABLE_FORMAT.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:813: case GL_TEXTURE_BASE_LEVEL:
I have not found the legal range of GL_TEXTURE_BASE_LEVEL and
GL_TEXTURE_MAX_LEVEL in specifications. Any advices?

[piman, 2015-05-11 21:39:34]

https://codereview.chromium.org/1133033002/diff/1/gpu/blink/webgraphicscontex...
File gpu/blink/webgraphicscontext3d_impl.cc (left):

https://codereview.chromium.org/1133033002/diff/1/gpu/blink/webgraphicscontex...
gpu/blink/webgraphicscontext3d_impl.cc:646: // TODO(kbr): figure out whether the
setting of TEXTURE_WRAP_R in
On 2015/05/11 07:17:14, legend wrote:
> @kbr and others, i'm not sure if this comment and related code could be
removed
> for supporting TEXTURE_WRAP_R.

FYI on ES, cube maps are always seamless regardless of wrap modes.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:813: case GL_TEXTURE_BASE_LEVEL:
On 2015/05/11 07:17:14, legend wrote:
> I have not found the legal range of GL_TEXTURE_BASE_LEVEL and
> GL_TEXTURE_MAX_LEVEL in specifications. Any advices?

In https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.4.pdf, section
"3.8.7 Texture Parameters", it says "any non-negative integer" for both, so you
have to check for that.

[Zhenyao Mo, 2015-05-11 23:23:44]

https://codereview.chromium.org/1133033002/diff/1/gpu/blink/webgraphicscontex...
File gpu/blink/webgraphicscontext3d_impl.cc (left):

https://codereview.chromium.org/1133033002/diff/1/gpu/blink/webgraphicscontex...
gpu/blink/webgraphicscontext3d_impl.cc:646: // TODO(kbr): figure out whether the
setting of TEXTURE_WRAP_R in
On 2015/05/11 07:17:14, legend wrote:
> @kbr and others, i'm not sure if this comment and related code could be
removed
> for supporting TEXTURE_WRAP_R.

Yes, remove it.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:854: 'GL_TEXTURE_3D',
put the ES3 specific ones under 'valid_es3'.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:1220: 'GL_TEXTURE_WRAP_R',
put the ES3 specific ones under 'valid_es3'.

[legend, 2015-05-12 02:34:17]

Please review again. Thanks!

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:854: 'GL_TEXTURE_3D',
On 2015/05/11 23:23:44, Zhenyao Mo wrote:
> put the ES3 specific ones under 'valid_es3'.

Done.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:1220: 'GL_TEXTURE_WRAP_R',
On 2015/05/11 23:23:44, Zhenyao Mo wrote:
> put the ES3 specific ones under 'valid_es3'.

Done.

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1133033002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:813: case GL_TEXTURE_BASE_LEVEL:
On 2015/05/11 21:39:34, piman (Very slow to review) wrote:
> On 2015/05/11 07:17:14, legend wrote:
> > I have not found the legal range of GL_TEXTURE_BASE_LEVEL and
> > GL_TEXTURE_MAX_LEVEL in specifications. Any advices?
> 
> In https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.4.pdf, section
> "3.8.7 Texture Parameters", it says "any non-negative integer" for both, so
you
> have to check for that.

Done.

[Zhenyao Mo, 2015-05-12 03:01:48]

LGTM

[piman, 2015-05-12 03:05:24]

lgtm

[legend, 2015-05-12 03:23:16]

One more small change. Please look again.

https://codereview.chromium.org/1133033002/diff/60001/gpu/blink/webgraphicsco...
File gpu/blink/webgraphicscontext3d_impl.cc (right):

https://codereview.chromium.org/1133033002/diff/60001/gpu/blink/webgraphicsco...
gpu/blink/webgraphicscontext3d_impl.cc:643: WGC3Denum, WGC3Denum, WGC3Dint);
Since the TODOs can be removed, here use the previous macro for `texParameteri`.

[legend, 2015-05-12 05:17:40]

The CQ bit was checked by guanxian.li@intel.com

[legend, 2015-05-12 05:17:40]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1133033002/#ps60001
(title: "Use previous macro")

[commit-bot: I haz the power, 2015-05-12 05:18:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133033002/60001

[commit-bot: I haz the power, 2015-05-12 07:11:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-12 07:12:11]

Patchset 4 (id:??) landed as
https://crrev.com/98291957a952d2fa956f760423425e4f9ce7a96f
Cr-Commit-Position: refs/heads/master@{#329367}

[legend, 2015-05-18 08:13:06]

Patchset #5 (id:80001) has been deleted