Enable proguard for apks

Enable proguard for apks

This moves a little bit more about how to run proguard for test apks into
proguard_utils.py and adds the gn rules/etc for running proguard on apks.

BUG=478319

[cjhopman, 2015-05-27 20:11:57]

cjhopman@chromium.org changed reviewers:
+ newt@chromium.org

[cjhopman, 2015-05-27 20:11:58]

newt: *

[newt (away), 2015-05-29 01:43:04]

lgtm after minor comments

https://codereview.chromium.org/1133013003/diff/40001/build/android/gyp/util/...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1133013003/diff/40001/build/android/gyp/util/...
build/android/gyp/util/proguard_util.py:92: assert len(self._configs) == 1, 'DO
NOT SUBMIT'
'DO NOT SUBMIT' ?

https://codereview.chromium.org/1133013003/diff/40001/build/android/gyp/util/...
build/android/gyp/util/proguard_util.py:152: open(self._outjar + '.dump',
'w').close()
Using 'w' will delete the existing contents of the file. Is that OK?

https://codereview.chromium.org/1133013003/diff/40001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1133013003/diff/40001/build/config/android/in...
build/config/android/internal_rules.gni:74: _output_jar_path =
invoker.output_jar_path
duplicate line

https://codereview.chromium.org/1133013003/diff/40001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1133013003/diff/40001/build/config/android/ru...
build/config/android/rules.gni:1445: inputs = [
funky indentation. this would be more normal:

    inputs = [
      _build_config,
      jar_path,
    ] + _proguard_configs

[cjhopman, 2015-06-30 23:26:12]

https://codereview.chromium.org/1133013003/diff/40001/build/android/gyp/util/...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1133013003/diff/40001/build/android/gyp/util/...
build/android/gyp/util/proguard_util.py:152: open(self._outjar + '.dump',
'w').close()
On 2015/05/29 01:43:04, newt wrote:
> Using 'w' will delete the existing contents of the file. Is that OK?

Yeah, that's intentional.

[cjhopman, 2015-06-30 23:26:19]

The CQ bit was checked by cjhopman@chromium.org

[cjhopman, 2015-06-30 23:26:20]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1133013003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-06-30 23:27:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133013003/100001

[commit-bot: I haz the power, 2015-06-30 23:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 23:37:28]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[cjhopman, 2015-07-06 22:03:10]

The CQ bit was checked by cjhopman@chromium.org

[cjhopman, 2015-07-06 22:03:10]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1133013003/#ps120001
(title: "fix deps")

[commit-bot: I haz the power, 2015-07-06 22:08:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133013003/120001

[commit-bot: I haz the power, 2015-07-06 22:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-06 22:59:20]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[newt (away), 2015-11-06 18:36:23]

newt@chromium.org changed reviewers:
+ agrieve@chromium.org

[newt (away), 2015-11-06 18:36:24]

agrieve: Is proguard already enabled for APKs, or if not could this be a useful
starting point?

My guess is this already happened elsewhere and we can just close this CL.

[agrieve, 2015-11-06 19:34:56]

On 2015/11/06 18:36:24, newt wrote:
> agrieve: Is proguard already enabled for APKs, or if not could this be a
useful
> starting point?
> 
> My guess is this already happened elsewhere and we can just close this CL.

We don't have proguard enabled yet for release builds despite having some
proguard logic for java_libararies. So... looks like it's probably more of a
good starting point. Thanks!

[agrieve, 2015-11-06 19:35:10]

Description was changed from

==========
Enable proguard for apks

This moves a little bit more about how to run proguard for test apks into
proguard_utils.py and adds the gn rules/etc for running proguard on apks.

BUG=478319
==========

to

==========
Enable proguard for apks

This moves a little bit more about how to run proguard for test apks into
proguard_utils.py and adds the gn rules/etc for running proguard on apks.

BUG=478319
==========

[newt (away), 2015-11-06 19:40:57]

Glad I asked :)