Fix copying from interstitial pages on OSX by going through the RenderWidgetHostDelegate.

content/browser/renderer_host/render_widget_host_view_mac.mm

Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index ccb1ecfe7b477cbb8c26063724def0a10130e70c..36ba4ad6cfa51e659d42697d364316596f02bc59 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -38,6 +38,7 @@
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_helper.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
 #import "content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h"
 #import "content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h"
 #import "content/browser/renderer_host/text_input_client_mac.h"
@@ -3256,45 +3257,45 @@ extern NSString *NSTextInputReplacementRangeAttributeName;
 }
 
 - (void)undo:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Undo();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Undo();

[nasko, 2015/05/13 17:24:08]

I think it is possible for the delegate of RenderWidgetHost to be nullptr, which
means this will crash in those cases.

[lgarron, 2015/05/13 21:58:41]

I've added a simple `if (!render_widget_host_delegate)` check.

(If that's not the idiomatic way to do this, let me know.)

[nasko, 2015/05/14 20:45:23]

Why not:

if (render_widget_host_delegate)
  render_widget_host_delegate->call()

 }
 
 - (void)redo:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Redo();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Redo();
 }
 
 - (void)cut:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Cut();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Cut();
 }
 
 - (void)copy:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Copy();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Copy();
 }
 
 - (void)copyToFindPboard:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->CopyToFindPboard();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->CopyToFindPboard();
 }
 
 - (void)paste:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Paste();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Paste();
 }
 
 - (void)pasteAndMatchStyle:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->PasteAndMatchStyle();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->PasteAndMatchStyle();
 }
 
 - (void)selectAll:(id)sender {
@@ -3305,9 +3306,9 @@ extern NSString *NSTextInputReplacementRangeAttributeName;
   // menu handler, neither is true.
   // Explicitly call SelectAll() here to make sure the renderer returns
   // selection results.
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->SelectAll();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->SelectAll();
 }
 
 - (void)startSpeaking:(id)sender {