Fix copying from interstitial pages on OSX by going through the RenderWidgetHostDelegate.

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import <objc/runtime.h>
 #include <OpenGL/gl.h>
 #include <QuartzCore/QuartzCore.h>
 
@@ skipping 20 matching lines @@
 #include "content/browser/bad_message.h"
 #import "content/browser/cocoa/system_hotkey_helper_mac.h"
 #import "content/browser/cocoa/system_hotkey_map.h"
 #include "content/browser/compositor/resize_lock.h"
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
 #include "content/browser/gpu/compositor_util.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_helper.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
 #import "content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h"
 #import "content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper.h"
 #import "content/browser/renderer_host/text_input_client_mac.h"
 #include "content/common/accessibility_messages.h"
 #include "content/common/edit_command.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/common/webplugin_geometry.h"
 #include "content/public/browser/browser_context.h"
@@ skipping 3198 matching lines @@
     WebMouseEvent event;
     event.type = WebInputEvent::MouseUp;
     event.button = WebMouseEvent::ButtonLeft;
     renderWidgetHostView_->ForwardMouseEvent(event);
 
     hasOpenMouseDown_ = NO;
   }
 }
 
 - (void)undo:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Undo();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Undo();

[nasko, 2015/05/13 17:24:08]

I think it is possible for the delegate of RenderWidgetHost to be nullptr, which
means this will crash in those cases.

[lgarron, 2015/05/13 21:58:41]

I've added a simple `if (!render_widget_host_delegate)` check.

(If that's not the idiomatic way to do this, let me know.)

[nasko, 2015/05/14 20:45:23]

Why not:

if (render_widget_host_delegate)
  render_widget_host_delegate->call()

 }
 
 - (void)redo:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Redo();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Redo();
 }
 
 - (void)cut:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Cut();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Cut();
 }
 
 - (void)copy:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Copy();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Copy();
 }
 
 - (void)copyToFindPboard:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->CopyToFindPboard();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->CopyToFindPboard();
 }
 
 - (void)paste:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->Paste();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->Paste();
 }
 
 - (void)pasteAndMatchStyle:(id)sender {
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->PasteAndMatchStyle();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->PasteAndMatchStyle();
 }
 
 - (void)selectAll:(id)sender {
   // editCommand_helper_ adds implementations for most NSResponder methods
   // dynamically. But the renderer side only sends selection results back to
   // the browser if they were triggered by a keyboard event or went through
   // one of the Select methods on RWH. Since selectAll: is called from the
   // menu handler, neither is true.
   // Explicitly call SelectAll() here to make sure the renderer returns
   // selection results.
-  WebContents* web_contents = renderWidgetHostView_->GetWebContents();
-  if (web_contents)
-    web_contents->SelectAll();
+  content::RenderWidgetHostDelegate* render_widget_host_delegate =
+      renderWidgetHostView_->render_widget_host_->GetDelegate();
+  render_widget_host_delegate->SelectAll();
 }
 
 - (void)startSpeaking:(id)sender {
   GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->SpeakSelection();
 }
 
 - (void)stopSpeaking:(id)sender {
   GetRenderWidgetHostViewToUse(renderWidgetHostView_.get())->StopSpeaking();
 }
 
@@ skipping 163 matching lines @@
 
 // "-webkit-app-region: drag | no-drag" is implemented on Mac by excluding
 // regions that are not draggable. (See ControlRegionView in
 // native_app_window_cocoa.mm). This requires the render host view to be
 // draggable by default.
 - (BOOL)mouseDownCanMoveWindow {
   return YES;
 }
 
 @end