Issue 1133002: First pass at a script for extracting licensing info from third_party.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133002: First pass at a script for extracting licensing info from third_party. (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
agl, M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Visibility:
Public.

Description

First pass at a script for extracting licensing info from third_party. I intend to use this to automate managing our license metadata. BUG=27639, 28291, 29342, 29764, 29765 ,others Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42005

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -0 lines)			Patch
	A	tools/licenses.py	View		1 chunk	+98 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

When you run this it complains about basically every directory we have. So next would ...

10 years, 9 months ago (2010-03-18 21:16:47 UTC) #1

agl

10 years, 9 months ago (2010-03-18 21:27:04 UTC) #2

LGTM

http://codereview.chromium.org/1133002/diff/1/2
File tools/licenses.py (right):

http://codereview.chromium.org/1133002/diff/1/2#newcode74
tools/licenses.py:74: skip_dirs = ('.svn', '.git',             # VCS metadata
This could be a set() these days. (Unimportant)

http://codereview.chromium.org/1133002/diff/1/2#newcode83
tools/licenses.py:83: for skip in skip_dirs:
If you make it a set, the order of these loops should be reversed.

Expand Messages | Collapse Messages