Chromium Code Reviews
Help | Chromium Project | Sign in
(56)

Issue 1133002: First pass at a script for extracting licensing info from third_party. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by Evan Martin
Modified:
3 years, 10 months ago
Reviewers:
agl, M-A Ruel
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

First pass at a script for extracting licensing info from third_party. I intend to use this to automate managing our license metadata. BUG=27639, 28291, 29342, 29764, 29765 ,others Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42005

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
A tools/licenses.py View 1 chunk +98 lines, -0 lines 2 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Evan Martin
When you run this it complains about basically every directory we have. So next would ...
5 years ago (2010-03-18 21:16:47 UTC) #1
agl
5 years ago (2010-03-18 21:27:04 UTC) #2
LGTM

http://codereview.chromium.org/1133002/diff/1/2
File tools/licenses.py (right):

http://codereview.chromium.org/1133002/diff/1/2#newcode74
tools/licenses.py:74: skip_dirs = ('.svn', '.git',             # VCS metadata
This could be a set() these days. (Unimportant)

http://codereview.chromium.org/1133002/diff/1/2#newcode83
tools/licenses.py:83: for skip in skip_dirs:
If you make it a set, the order of these loops should be reversed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted