Issue 1132983007: [Layout] Put in some guards to prevent us from reintroducing 'display' properties into the CSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132983007: [Layout] Put in some guards to prevent us from reintroducing 'display' properties into the CSS. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Layout] Put in some guards to prevent us from reintroducing 'display' properties into the CSS. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ed8ffbdbf1e9d8d75cbbe7e6ed3475c6b81ebac1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -26 lines)			Patch
M	sky/examples/stocks/lib/stock_arrow.dart	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/examples/stocks/lib/stock_row.dart	View	1 2 3	3 chunks	+8 lines, -9 lines	0 comments	Download
M	sky/framework/components/menu_item.dart	View	1 2 3	2 chunks	+10 lines, -6 lines	0 comments	Download
M	sky/framework/layout.dart	View	1 2 3	5 chunks	+14 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Hixie

On 2015/05/14 at 22:38:33, eseidel wrote: > lgtm I'm delaying checking this in until noon ...

5 years, 7 months ago (2015-05-14 22:56:35 UTC) #3

Hixie

5 years, 7 months ago (2015-05-15 22:16:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
ed8ffbdbf1e9d8d75cbbe7e6ed3475c6b81ebac1 (presubmit successful).