sky/examples/stocks/lib/stock_arrow.dart - Issue 1132983007: [Layout] Put in some guards to prevent us from reintroducing 'display' properties into the CSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/examples/stocks/lib/stock_arrow.dart

Issue 1132983007: [Layout] Put in some guards to prevent us from reintroducing 'display' properties into the CSS. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: git cl status Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/examples/stocks/lib/stock_arrow.dart

diff --git a/sky/examples/stocks/lib/stock_arrow.dart b/sky/examples/stocks/lib/stock_arrow.dart

index 78a4b66ee7d579a8565ee3da52bd10a0d5d9ec28..5395984f25cb2daaed62dc06fe9d2d151eddabf4 100644

--- a/sky/examples/stocks/lib/stock_arrow.dart

+++ b/sky/examples/stocks/lib/stock_arrow.dart

@@ -4,13 +4,12 @@

import 'dart:math';

import 'package:sky/framework/fn.dart';

+import 'package:sky/framework/layout.dart';

class StockArrow extends Component {

static final Style _style = new Style('''

width: 40px;

height: 40px;

- display: flex;

- flex-direction: row;

align-items: center;

justify-content: center;

border-radius: 40px;

@@ -79,8 +78,9 @@ class StockArrow extends Component {

bool up = percentChange > 0;

String type = up ? 'bottom' : 'top';

- return new Container(

+ return new FlexContainer(

inlineStyle: 'border-color: $border',

+ direction: FlexDirection.Row,

style: _style,

children: [

new Container(

« no previous file with comments | « no previous file | sky/examples/stocks/lib/stock_row.dart » ('j') | no next file with comments »