Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1132913002: Remove RenderThreadImpl::DoNotSuspendWebKitSharedTimer (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RenderThreadImpl::DoNotSuspendWebKitSharedTimer Shared timers are explicitly suppressed when sending a sync IPC that runs a nested message loop. Historically, there was an affordance for avoiding this suppression, but it appears that is no longer necessary. Remove RenderThreadImpl::DoNotSuspendWebKitSharedTimer accordingly. BUG=none Committed: https://crrev.com/d73ae541700c2659c79409d937a9fd531c5d5d46 Cr-Commit-Position: refs/heads/master@{#329225}

Patch Set 1 : Cleanup #

Patch Set 2 : Cleanup comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -32 lines) Patch
M content/renderer/render_thread_impl.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +15 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jdduke (slow)
sievers@, PTAL, appears this method is no longer used and just adds complexity.
5 years, 7 months ago (2015-05-11 15:15:04 UTC) #3
no sievers
LGTM
5 years, 7 months ago (2015-05-11 19:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132913002/40001
5 years, 7 months ago (2015-05-11 20:03:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-11 20:07:27 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 20:08:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d73ae541700c2659c79409d937a9fd531c5d5d46
Cr-Commit-Position: refs/heads/master@{#329225}

Powered by Google App Engine
This is Rietveld 408576698