Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: content/renderer/render_thread_impl.h

Issue 1132913002: Remove RenderThreadImpl::DoNotSuspendWebKitSharedTimer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 cc::TaskGraphRunner* GetTaskGraphRunner() override; 207 cc::TaskGraphRunner* GetTaskGraphRunner() override;
208 bool IsGatherPixelRefsEnabled() override; 208 bool IsGatherPixelRefsEnabled() override;
209 209
210 // Synchronously establish a channel to the GPU plugin if not previously 210 // Synchronously establish a channel to the GPU plugin if not previously
211 // established or if it has been lost (for example if the GPU plugin crashed). 211 // established or if it has been lost (for example if the GPU plugin crashed).
212 // If there is a pending asynchronous request, it will be completed by the 212 // If there is a pending asynchronous request, it will be completed by the
213 // time this routine returns. 213 // time this routine returns.
214 GpuChannelHost* EstablishGpuChannelSync(CauseForGpuLaunch); 214 GpuChannelHost* EstablishGpuChannelSync(CauseForGpuLaunch);
215 215
216 216
217 // These methods modify how the next message is sent. Normally, when sending 217 // This method modifies how the next message is sent. Normally, when sending
218 // a synchronous message that runs a nested message loop, we need to suspend 218 // a synchronous message that runs a nested message loop, we need to suspend
219 // callbacks into WebKit. This involves disabling timers and deferring 219 // callbacks into WebKit. This involves disabling timers and deferring
220 // resource loads. However, there are exceptions when we need to customize 220 // resource loads. However, there are exceptions when we need to customize
221 // the behavior. 221 // the behavior.
222 void DoNotSuspendWebKitSharedTimer();
223 void DoNotNotifyWebKitOfModalLoop(); 222 void DoNotNotifyWebKitOfModalLoop();
224 223
225 // True if we are running layout tests. This currently disables forwarding 224 // True if we are running layout tests. This currently disables forwarding
226 // various status messages to the console, skips network error pages, and 225 // various status messages to the console, skips network error pages, and
227 // short circuits size update and focus events. 226 // short circuits size update and focus events.
228 bool layout_test_mode() const { 227 bool layout_test_mode() const {
229 return layout_test_mode_; 228 return layout_test_mode_;
230 } 229 }
231 void set_layout_test_mode(bool layout_test_mode) { 230 void set_layout_test_mode(bool layout_test_mode) {
232 layout_test_mode_ = layout_test_mode; 231 layout_test_mode_ = layout_test_mode;
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 525
527 // The count of hidden RenderWidgets running through this thread. 526 // The count of hidden RenderWidgets running through this thread.
528 int hidden_widget_count_; 527 int hidden_widget_count_;
529 528
530 // The current value of the idle notification timer delay. 529 // The current value of the idle notification timer delay.
531 int64 idle_notification_delay_in_ms_; 530 int64 idle_notification_delay_in_ms_;
532 531
533 // The number of idle handler calls that skip sending idle notifications. 532 // The number of idle handler calls that skip sending idle notifications.
534 int idle_notifications_to_skip_; 533 int idle_notifications_to_skip_;
535 534
536 bool suspend_webkit_shared_timer_;
537 bool notify_webkit_of_modal_loop_; 535 bool notify_webkit_of_modal_loop_;
538 bool webkit_shared_timer_suspended_; 536 bool webkit_shared_timer_suspended_;
539 537
540 // The following flag is used to control layout test specific behavior. 538 // The following flag is used to control layout test specific behavior.
541 bool layout_test_mode_; 539 bool layout_test_mode_;
542 540
543 // Timer that periodically calls IdleHandler. 541 // Timer that periodically calls IdleHandler.
544 base::RepeatingTimer<RenderThreadImpl> idle_timer_; 542 base::RepeatingTimer<RenderThreadImpl> idle_timer_;
545 543
546 // The channel from the renderer process to the GPU process. 544 // The channel from the renderer process to the GPU process.
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl); 648 DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl);
651 }; 649 };
652 650
653 #if defined(COMPILER_MSVC) 651 #if defined(COMPILER_MSVC)
654 #pragma warning(pop) 652 #pragma warning(pop)
655 #endif 653 #endif
656 654
657 } // namespace content 655 } // namespace content
658 656
659 #endif // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_ 657 #endif // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698