Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1132853005: Sk4px: SrcATop, DstATop, Xor, Multiply (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4px: SrcATop, DstATop, Xor, Multiply SSE runs 2-3x faster (than 4f), NEON runs 1.2-1.4x faster (than existing NEON). Small diffs on {aarectmodes, imagefilters_xfermodes, hairmodes, mixed_xfermodes} only on AA edges due to precision drop. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2d8d33e9e825f9919875be64a71b746189b385be

Patch Set 1 #

Patch Set 2 : multiply too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M src/core/Sk4px.h View 1 chunk +9 lines, -8 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 6 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein_C
5 years, 7 months ago (2015-05-13 19:56:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132853005/1
5 years, 7 months ago (2015-05-13 19:57:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 20:02:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132853005/20001
5 years, 7 months ago (2015-05-13 20:21:00 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 20:27:14 UTC) #10
reed1
lgtm
5 years, 7 months ago (2015-05-13 21:07:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132853005/20001
5 years, 7 months ago (2015-05-13 21:08:31 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 21:08:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2d8d33e9e825f9919875be64a71b746189b385be

Powered by Google App Engine
This is Rietveld 408576698