Issue 1132803004: ozone: drm: Fix graphics buffer handle leak in DrmConsoleBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132803004: ozone: drm: Fix graphics buffer handle leak in DrmConsoleBuffer (Closed)

Created:
5 years, 7 months ago by spang

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

ozone: drm: Fix graphics buffer handle leak in DrmConsoleBuffer We are leaking graphics buffer handles every time we plug in a display. The handle is created by DRM_IOCTL_MODE_GETFB. This adds a call to DRM_IOCTL_GEM_CLOSE to release the handle. BUG=470772 TEST=plug & unplug HDMI repeatedly. No significant increase in shared memory usage over time (as reported by "free" command). Review URL: https://codereview.chromium.org/1080923006 Cr-Commit-Position: refs/heads/master@{#325769} (cherry picked from commit 756bbb93152e169e92e5e21b82ba724dac2f1822) Committed: https://chromium.googlesource.com/chromium/src/+/0376981a83a48758bd3cbf6cd4337feb151e535f

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -0 lines)			Patch
M	ui/ozone/platform/drm/gpu/drm_console_buffer.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/ozone/platform/drm/gpu/drm_device.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/ozone/platform/drm/gpu/drm_device.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ui/ozone/platform/drm/test/mock_drm_device.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/ozone/platform/drm/test/mock_drm_device.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

spang

5 years, 7 months ago (2015-05-12 04:44:26 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0376981a83a48758bd3cbf6cd4337feb151e535f.

Expand Messages | Collapse Messages