Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1080923006: ozone: drm: Fix graphics buffer handle leak in DrmConsoleBuffer (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
Reviewers:
marcheu, dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: drm: Fix graphics buffer handle leak in DrmConsoleBuffer We are leaking graphics buffer handles every time we plug in a display. The handle is created by DRM_IOCTL_MODE_GETFB. This adds a call to DRM_IOCTL_GEM_CLOSE to release the handle. BUG=470772 TEST=plug & unplug HDMI repeatedly. No significant increase in shared memory usage over time (as reported by "free" command). Committed: https://crrev.com/756bbb93152e169e92e5e21b82ba724dac2f1822 Cr-Commit-Position: refs/heads/master@{#325769}

Patch Set 1 #

Patch Set 2 : switch to DRM_IOCTL_GEM_CLOSE per marcheu@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ui/ozone/platform/drm/gpu/drm_console_buffer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
I'm stumped as to why this code is running every time a monitor gets plugged ...
5 years, 8 months ago (2015-04-18 01:33:58 UTC) #2
marcheu
lgtm
5 years, 8 months ago (2015-04-18 02:15:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1080923006/20001
5 years, 8 months ago (2015-04-18 02:16:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-18 02:40:47 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/756bbb93152e169e92e5e21b82ba724dac2f1822 Cr-Commit-Position: refs/heads/master@{#325769}
5 years, 8 months ago (2015-04-18 02:41:34 UTC) #7
dnicoara
5 years, 8 months ago (2015-04-20 13:39:17 UTC) #8
Message was sent while issue was closed.
On 2015/04/18 01:33:58, spang wrote:
> I'm stumped as to why this code is running every time a monitor gets plugged
in
> - isn't it just for internal display on boot?
> 
> Anyway, this plugs the leak.

It isn't necessarily the internal display. It is the display showing the boot
splash. Also the concept of "on boot" is hard to figure out.

Powered by Google App Engine
This is Rietveld 408576698