Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1132793004: Add sky_server for mac host (Closed)

Created:
5 years, 7 months ago by toshik
Modified:
5 years, 7 months ago
Reviewers:
cdotstout, jamesr, eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add sky_server for mac host Modified download_sky_server to choose a different sha1 file depending on the host platform so that it downloads a correct sky_server executable. BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : added upload_sky_server #

Patch Set 3 : updated upload_sky_server #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M sky/tools/download_sky_server View 2 chunks +11 lines, -1 line 1 comment Download
M sky/tools/skygo/README View 1 1 chunk +6 lines, -4 lines 0 comments Download
D sky/tools/skygo/sky_server.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A + sky/tools/skygo/sky_server_linux.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A sky/tools/skygo/sky_server_mac.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A sky/tools/upload_sky_server View 1 2 1 chunk +58 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
toshik
5 years, 7 months ago (2015-05-12 22:35:17 UTC) #2
jamesr
https://codereview.chromium.org/1132793004/diff/1/sky/tools/skygo/README File sky/tools/skygo/README (right): https://codereview.chromium.org/1132793004/diff/1/sky/tools/skygo/README#newcode17 sky/tools/skygo/README:17: sky_server.sha1. If you uploaded sky_server for linux, overwrite can ...
5 years, 7 months ago (2015-05-14 23:47:06 UTC) #3
toshik
https://codereview.chromium.org/1132793004/diff/1/sky/tools/skygo/README File sky/tools/skygo/README (right): https://codereview.chromium.org/1132793004/diff/1/sky/tools/skygo/README#newcode17 sky/tools/skygo/README:17: sky_server.sha1. If you uploaded sky_server for linux, overwrite On ...
5 years, 7 months ago (2015-05-15 04:54:19 UTC) #4
toshik
added upload_sky_server script
5 years, 7 months ago (2015-05-15 18:02:02 UTC) #5
jamesr
https://codereview.chromium.org/1132793004/diff/40001/sky/tools/download_sky_server File sky/tools/download_sky_server (right): https://codereview.chromium.org/1132793004/diff/40001/sky/tools/download_sky_server#newcode17 sky/tools/download_sky_server:17: 'linux2': 'linux', i wouldn't add win entries and instead ...
5 years, 7 months ago (2015-05-21 21:33:05 UTC) #6
eseidel
I didn't know this existed and wrote https://codereview.chromium.org/1150033006/ this afternoon. I prefer the DEPS-based approach ...
5 years, 7 months ago (2015-05-26 23:34:34 UTC) #8
toshik
5 years, 7 months ago (2015-05-27 19:50:00 UTC) #9
Yeah, I started this CL but was not updating it in a timely manner. I think the
DEPS-based approach makes sense. Thanks for fixing it!

Powered by Google App Engine
This is Rietveld 408576698