sky/tools/skygo/README - Issue 1132793004: Add sky_server for mac host

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/tools/skygo/README

Issue 1132793004: Add sky_server for mac host (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 sky_server instructions	1 sky_server instructions

2 #######################	2 #######################

3	3

4 Building locally:	4 Building locally:

5 1. cd sky/tools/skygo	5 1. cd sky/tools/skygo

6 2. go build sky_server.go	6 2. go build sky_server.go

7	7

8 Testing locally:	8 Testing locally:

9 1. Build as per the above steps	9 1. Build as per the above steps

10 2. Run test_sky --path-to-server /absolute/path/to/sky/tools/skygo/sky_server	10 2. Run test_sky --path-to-server /absolute/path/to/sky/tools/skygo/sky_server

11	11

12 Uploading the locally built server	12 Uploading the locally built server

13 1. cd sky/tools/skygo	13 1. cd sky/tools/skygo

14 2. upload_to_google_storage.py --bucket mojo sky_server	14 2. upload_to_google_storage.py --bucket mojo sky_server

15	15

16 upload_to_google_storage.py is in depot_tools. It will overwrite	16 upload_to_google_storage.py is in depot_tools. It will generate

17 sky_server.sha1. Include that change in your code review.	17 sky_server.sha1. If you uploaded sky_server for linux, overwrite
	jamesr 2015/05/14 23:47:05 can you make upload_to_google_storage.py simply ov can you make upload_to_google_storage.py simply overwrite the correct sha1? toshik 2015/05/15 04:54:18 We can write a script to do it automatically. I do Show quoted text On 2015/05/14 23:47:05, jamesr wrote: > can you make upload_to_google_storage.py simply overwrite the correct sha1? We can write a script to do it automatically. I don't think upload_to_google_storage.py should care if the uploading file is platform dependent or not. I like the current simple behavior, which always generates $(filename).sha1.
	18 sky_server_linux.sha1 with it. If you uploaded sky_server for mac,

	19 overwrite sky_server_mac.sha1. Include that change in your code review.

18	20

19 sky_server was last built using go version go1.4.2 linux/amd64.	21 sky_server was last built using go version go1.4.2 linux/amd64.

OLD	NEW

« no previous file with comments | « sky/tools/download_sky_server ('k') | sky/tools/skygo/sky_server.sha1 » ('j') | no next file with comments »