Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132793002: DevTools: do not enable debugger for pages where script execution is prohibited (Closed)

Created:
5 years, 7 months ago by yurys
Modified:
5 years, 7 months ago
Reviewers:
kozy, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org, horo
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: do not enable debugger for pages where script execution is prohibited This CL fixes WorkerDevToolsSanityTest.InspectSharedWorker by checking that adding ScriptDebugListener to the server has succeeded. For worker shadow pages it will fail and the agent should report that and stay disabled. Long-term fix would be not to instantiate debugger agent at all for the shadow pages. BUG=485898 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195117

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M Source/core/inspector/InspectorDebuggerAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
yurys
5 years, 7 months ago (2015-05-08 13:04:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132793002/1
5 years, 7 months ago (2015-05-08 13:05:23 UTC) #4
sergeyv
https://codereview.chromium.org/1132793002/diff/1/Source/bindings/core/v8/PageScriptDebugServer.cpp File Source/bindings/core/v8/PageScriptDebugServer.cpp (right): https://codereview.chromium.org/1132793002/diff/1/Source/bindings/core/v8/PageScriptDebugServer.cpp#newcode108 Source/bindings/core/v8/PageScriptDebugServer.cpp:108: if (!scriptController.canExecuteScripts(NotAboutToExecuteScript)) Lets make this check earlier - in ...
5 years, 7 months ago (2015-05-08 13:11:42 UTC) #5
yurys
https://codereview.chromium.org/1132793002/diff/1/Source/bindings/core/v8/PageScriptDebugServer.cpp File Source/bindings/core/v8/PageScriptDebugServer.cpp (right): https://codereview.chromium.org/1132793002/diff/1/Source/bindings/core/v8/PageScriptDebugServer.cpp#newcode108 Source/bindings/core/v8/PageScriptDebugServer.cpp:108: if (!scriptController.canExecuteScripts(NotAboutToExecuteScript)) On 2015/05/08 13:11:42, sergeyv wrote: > Lets ...
5 years, 7 months ago (2015-05-08 13:21:15 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132793002/100001
5 years, 7 months ago (2015-05-08 13:23:25 UTC) #13
sergeyv
lgtm
5 years, 7 months ago (2015-05-08 13:24:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132793002/100001
5 years, 7 months ago (2015-05-08 13:37:11 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 14:48:26 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195117

Powered by Google App Engine
This is Rietveld 408576698