DevTools: do not enable debugger for pages where script execution is prohibited

Source/bindings/core/v8/PageScriptDebugServer.cpp

 /*
  * Copyright (c) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 82 matching lines @@
 #endif
     ScriptDebugServer::trace(visitor);
 }
 
 void PageScriptDebugServer::setContextDebugData(v8::Local<v8::Context> context, const String& type, int contextDebugId)
 {
     String debugData = "[" + type + "," + String::number(contextDebugId) + "]";
     ScriptDebugServer::setContextDebugData(context, debugData);
 }
 
-void PageScriptDebugServer::addListener(ScriptDebugListener* listener, LocalFrame* localFrameRoot, int contextDebugId)
+bool PageScriptDebugServer::addListener(ScriptDebugListener* listener, LocalFrame* localFrameRoot, int contextDebugId)
 {
     ASSERT(localFrameRoot == localFrameRoot->localFrameRoot());
 
     ScriptController& scriptController = localFrameRoot->script();
     if (!scriptController.canExecuteScripts(NotAboutToExecuteScript))

[sergeyv, 2015/05/08 13:11:42]

Lets make this check earlier - in the enable method PageDebuggerAgent

[yurys, 2015/05/08 13:21:14]

Done.

-        return;
+        return false;
 
     if (m_listenersMap.isEmpty())
         enable();
     m_listenersMap.set(localFrameRoot, listener);
     String contextDataSubstring = "," + String::number(contextDebugId) + "]";
     reportCompiledScripts(contextDataSubstring, listener);
+    return true;
 }
 
 void PageScriptDebugServer::removeListener(ScriptDebugListener* listener, LocalFrame* localFrame)
 {
     if (!m_listenersMap.contains(localFrame))
         return;
 
     if (m_pausedFrame == localFrame)
         continueProgram();
 
@@ skipping 74 matching lines @@
 
     m_pausedFrame = 0;
 }
 
 void PageScriptDebugServer::quitMessageLoopOnPause()
 {
     m_clientMessageLoop->quitNow();
 }
 
 } // namespace blink