components/scheduler/child/test_time_source.h - Issue 1132753008: Replaced TestNowSource with SimpleTestTickClock.

Unified Diff: components/scheduler/child/test_time_source.h

Issue 1132753008: Replaced TestNowSource with SimpleTestTickClock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Corrected typo. Minor changes to keep parity with TestNowSource. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/scheduler/child/test_time_source.h

diff --git a/components/scheduler/child/test_time_source.h b/components/scheduler/child/test_time_source.h

index 6219a4dbd8afa92b0d0d7f5c4bdbab197f661243..31ad017b8f887597e0ca5568999521df2ccfae98 100644

--- a/components/scheduler/child/test_time_source.h

+++ b/components/scheduler/child/test_time_source.h

@@ -6,23 +6,23 @@

#define COMPONENTS_SCHEDULER_CHILD_TEST_TIME_SOURCE_H_

#include "base/memory/ref_counted.h"

+#include "base/test/simple_test_tick_clock.h"

#include "components/scheduler/child/time_source.h"

-namespace cc {

-class TestNowSource;

namespace scheduler {

class TestTimeSource : public TimeSource {

public:

- explicit TestTimeSource(scoped_refptr<cc::TestNowSource> time_source);

+ explicit TestTimeSource(base::SimpleTestTickClock* time_source);

~TestTimeSource() override;

base::TimeTicks Now() const override;

+ int NumNowCalls() const { return num_now_calls_; }

private:

- scoped_refptr<cc::TestNowSource> time_source_;

+ base::SimpleTestTickClock* time_source_;

+ mutable int num_now_calls_;

mithro-old 2015/05/29 08:26:48 The mutable keyword doesn't do what you probably t

Ankur Verma 2015/06/01 05:30:44 Shall remove this if its not really mutable.

mithro-old 2015/06/01 07:32:15 I don't think you should add the NumNowCalls() fun

Ankur Verma 2015/06/01 09:21:40 Right. I've put in my thoughts in relation to this

Ankur Verma 2015/06/03 14:56:10 Done.

DISALLOW_COPY_AND_ASSIGN(TestTimeSource);

};