Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1098033002: Remove dependency on cc::TestNowSource from scheduler code (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
Sami
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+watch, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on cc::TestNowSource from scheduler code BUG=478736 R=skyostil@chromium.org Committed: https://crrev.com/a3635a7de383a295e52a35c1ae4e72aecab14d77 Cr-Commit-Position: refs/heads/master@{#326006}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -47 lines) Patch
M content/child/scheduler/scheduler_helper.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/child/scheduler/scheduler_helper.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M content/child/scheduler/scheduler_helper_unittest.cc View 2 chunks +7 lines, -1 line 0 comments Download
M content/child/scheduler/task_queue_manager.h View 4 chunks +5 lines, -7 lines 0 comments Download
M content/child/scheduler/task_queue_manager.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/child/scheduler/task_queue_manager_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download
A content/child/scheduler/time_source.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + content/child/scheduler/time_source.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/child/scheduler/worker_scheduler_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/scheduler/worker_scheduler_impl.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/child/scheduler/worker_scheduler_impl_unittest.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl_unittest.cc View 1 2 8 chunks +37 lines, -7 lines 0 comments Download
A content/test/test_time_source.h View 1 chunk +32 lines, -0 lines 0 comments Download
A content/test/test_time_source.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/ubsan/blacklist.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-20 18:27:28 UTC) #1
Sami
lgtm, thanks for fixing this! https://codereview.chromium.org/1098033002/diff/1/content/child/scheduler/task_queue_manager.h File content/child/scheduler/task_queue_manager.h (right): https://codereview.chromium.org/1098033002/diff/1/content/child/scheduler/task_queue_manager.h#newcode125 content/child/scheduler/task_queue_manager.h:125: void SetTimeSourceForTesting(scoped_ptr<TimeSource> time_source); Passing ...
5 years, 8 months ago (2015-04-20 18:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098033002/20001
5 years, 8 months ago (2015-04-20 18:44:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/13900)
5 years, 8 months ago (2015-04-20 21:01:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098033002/40001
5 years, 8 months ago (2015-04-21 08:16:00 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-21 10:29:00 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 10:29:53 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3635a7de383a295e52a35c1ae4e72aecab14d77
Cr-Commit-Position: refs/heads/master@{#326006}

Powered by Google App Engine
This is Rietveld 408576698