Added msvs_application_type_revision for winrt compilation

Added msvs_application_type_revision for winrt compilation

With the introduction of Windows 10 Universal applications, winrt app projects require a different application revision type.  This change allows this value to customized in the GYP.

Patch from coopp@microsoft.com.

R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/9f594095c5b14f8bc518081a660e77890c294861

[coop, 2015-05-12 18:39:20]

coopp@microsoft.com changed reviewers:
+ scottmg@chromium.org

[coop, 2015-05-13 22:08:06]

I am not sure if I submitted my review properly.

[scottmg, 2015-05-13 22:17:33]

You have to 'm'ail before reviewers are notified that the review is ready to
look at, if that was the confusion.

https://codereview.chromium.org/1132743006/diff/1/test/win/enable-winrt/enabl...
File test/win/enable-winrt/enable-winrt.gyp (right):

https://codereview.chromium.org/1132743006/diff/1/test/win/enable-winrt/enabl...
test/win/enable-winrt/enable-winrt.gyp:8: 'target_name':
'enable_winrt_81_revision_dll',
these would be better in a separate file, maybe winrt-app-type-revision.gyp.

https://codereview.chromium.org/1132743006/diff/1/test/win/enable-winrt/enabl...
test/win/enable-winrt/enable-winrt.gyp:11: 'msvs_application_type_revision' :
'8.1'
nit; can you remove the space before : to match the rest of the file (and in the
other two targets too)?

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
File test/win/gyptest-link-enable-winrt-app-revision.py (right):

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt-app-revision.py:30:
test.build('enable-winrt.gyp', 'enable_winrt_81_revision_dll', chdir=CHDIR)
and only refer to the new .gyp file here (removing the enable-winrt ones)

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
File test/win/gyptest-link-enable-winrt.py (right):

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt.py:30: test.build('enable-winrt.gyp',
'enable_winrt_81_revision_dll', chdir=CHDIR)
then remove these from here

[coop, 2015-05-13 22:40:51]

Incorporated code review feedback.

https://codereview.chromium.org/1132743006/diff/1/test/win/enable-winrt/enabl...
File test/win/enable-winrt/enable-winrt.gyp (right):

https://codereview.chromium.org/1132743006/diff/1/test/win/enable-winrt/enabl...
test/win/enable-winrt/enable-winrt.gyp:8: 'target_name':
'enable_winrt_81_revision_dll',
On 2015/05/13 22:17:32, scottmg wrote:
> these would be better in a separate file, maybe winrt-app-type-revision.gyp.

Done.

https://codereview.chromium.org/1132743006/diff/1/test/win/enable-winrt/enabl...
test/win/enable-winrt/enable-winrt.gyp:11: 'msvs_application_type_revision' :
'8.1'
On 2015/05/13 22:17:32, scottmg wrote:
> nit; can you remove the space before : to match the rest of the file (and in
the
> other two targets too)?

Done.

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
File test/win/gyptest-link-enable-winrt-app-revision.py (right):

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt-app-revision.py:30:
test.build('enable-winrt.gyp', 'enable_winrt_81_revision_dll', chdir=CHDIR)
On 2015/05/13 22:17:32, scottmg wrote:
> and only refer to the new .gyp file here (removing the enable-winrt ones)

Done.

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
File test/win/gyptest-link-enable-winrt.py (right):

https://codereview.chromium.org/1132743006/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt.py:30: test.build('enable-winrt.gyp',
'enable_winrt_81_revision_dll', chdir=CHDIR)
On 2015/05/13 22:17:33, scottmg wrote:
> then remove these from here

Done.

[scottmg, 2015-05-13 22:48:15]

https://codereview.chromium.org/1132743006/diff/20001/test/win/gyptest-link-e...
File test/win/gyptest-link-enable-winrt-app-revision.py (right):

https://codereview.chromium.org/1132743006/diff/20001/test/win/gyptest-link-e...
test/win/gyptest-link-enable-winrt-app-revision.py:29: chdir=CHDIR)
Is there anything we could check in either the binary or via a #define or
something that this is really working? We don't really verify if 81 or 82 was
actually set.

[coop, 2015-05-14 16:54:18]

On 2015/05/13 22:48:15, scottmg wrote:
>
https://codereview.chromium.org/1132743006/diff/20001/test/win/gyptest-link-e...
> File test/win/gyptest-link-enable-winrt-app-revision.py (right):
> 
>
https://codereview.chromium.org/1132743006/diff/20001/test/win/gyptest-link-e...
> test/win/gyptest-link-enable-winrt-app-revision.py:29: chdir=CHDIR)
> Is there anything we could check in either the binary or via a #define or
> something that this is really working? We don't really verify if 81 or 82 was
> actually set.

Let me look a little today and I will get back to you.

[coop, 2015-05-14 20:52:18]

On 2015/05/14 16:54:18, coop wrote:
> On 2015/05/13 22:48:15, scottmg wrote:
> >
>
https://codereview.chromium.org/1132743006/diff/20001/test/win/gyptest-link-e...
> > File test/win/gyptest-link-enable-winrt-app-revision.py (right):
> > 
> >
>
https://codereview.chromium.org/1132743006/diff/20001/test/win/gyptest-link-e...
> > test/win/gyptest-link-enable-winrt-app-revision.py:29: chdir=CHDIR)
> > Is there anything we could check in either the binary or via a #define or
> > something that this is really working? We don't really verify if 81 or 82
was
> > actually set.
> 
> Let me look a little today and I will get back to you.

Ok.  Let me give you a rundown and ask for some advice.

I tried a bunch of things and found what I think is an interesting Visual Studio
2015 behavior.
If you construct an application in VS2015 targeted with a minimal visual studio
version of 14.0
+ v140 toolset setting, the following behaviors occur:

Visual Studio 2015 Project (for Windows Universal -- Windows 10)
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
<PlatformToolset>v140</PlatformToolset>

<ApplicationTypeRevision>8.2</ApplicationTypeRevision> = works
<ApplicationTypeRevision>8.1</ApplicationTypeRevision> = works
<ApplicationTypeRevision>999</ApplicationTypeRevision> = works
'<ApplicationTypeRevision>' completely missing = works

If you construct an application in VS2015 targeted with a minimal visual studio
version of 12.0
+ v120 toolset setting, the following behaviors occur:

Visual Studio 2015 Project (for Windows 8.1)
<MinimumVisualStudioVersion>12.0</MinimumVisualStudioVersion>
<PlatformToolset>v120</PlatformToolset>

<ApplicationTypeRevision>8.1</ApplicationTypeRevision> = works
<ApplicationTypeRevision>8.2</ApplicationTypeRevision> = fails, 'The build tools
for v120 (Platform Toolset = 'v120) cannot be found
<ApplicationTypeRevision>999</ApplicationTypeRevision> = fails, 'The build tools
for v120 (Platform Toolset = 'v120) cannot be found
'<ApplicationTypeRevision>' completely missing = works

It appears that the combination of PlatformToolset + <ApplicationTypeRevision>
setting effect the build of the app.

What kind of tests do you think I should author to cover this case?
** I am leaning towards have a test that generates using VS2013 + enable_winrt,
which would give me a ToolSet of v120 and add positve + negative tests
around setting the <ApplicationTypeRevision> value.

** In addition to the above test, I think I should also generate using VS2015  +
enable_winrt which would give me a ToolSet of v140 and ensure that succeeds.

Thoughts?

[coop, 2015-05-14 23:44:27]

I updated the test to use vs2013 instead of 2015.  2015 is too forgiving for
this value.  Also it looks like toolset is auto populated according to the
msvs_version.  So if I specify VS2015 I get 140 toolset, VS2013 I get 120.  This
test at least validates that revision is changing and effecting the builds.

[scottmg, 2015-05-15 00:03:01]

lgtm

[scottmg, 2015-05-15 00:08:09]

Committed patchset #3 (id:40001) manually as
9f594095c5b14f8bc518081a660e77890c294861.