Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: test/win/winrt-app-type-revision/winrt-app-type-revison.gyp

Issue 1132743006: Added msvs_application_type_revision for winrt compilation (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Moved test to use 2013 which validates revision values during compilation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/win/winrt-app-type-revision/dllmain.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/winrt-app-type-revision/winrt-app-type-revison.gyp
diff --git a/test/win/enable-winrt/enable-winrt.gyp b/test/win/winrt-app-type-revision/winrt-app-type-revison.gyp
similarity index 66%
copy from test/win/enable-winrt/enable-winrt.gyp
copy to test/win/winrt-app-type-revision/winrt-app-type-revison.gyp
index 69f70189db94de5d35eede52d8075fcb5c72514c..5f37b5a2aba5fe51c118540f81c0cb80c7814e8d 100644
--- a/test/win/enable-winrt/enable-winrt.gyp
+++ b/test/win/winrt-app-type-revision/winrt-app-type-revison.gyp
@@ -5,28 +5,32 @@
{
'targets': [
{
- 'target_name': 'enable_winrt_dll',
+ 'target_name': 'enable_winrt_81_revision_dll',
'type': 'shared_library',
'msvs_enable_winrt': 1,
+ 'msvs_application_type_revision': '8.1'
'sources': [
'dllmain.cc',
],
},
{
- 'target_name': 'enable_winrt_missing_dll',
+ 'target_name': 'enable_winrt_82_revision_dll',
'type': 'shared_library',
+ 'msvs_enable_winrt': 1,
+ 'msvs_application_type_revision': '8.2'
'sources': [
'dllmain.cc',
],
},
{
- 'target_name': 'enable_winrt_winphone_dll',
+ 'target_name': 'enable_winrt_invalid_revision_dll',
'type': 'shared_library',
'msvs_enable_winrt': 1,
- 'msvs_enable_winphone': 1,
+ 'msvs_application_type_revision': '999'
'sources': [
'dllmain.cc',
],
+ },
'msvs_settings': {
'VCLinkerTool': {
'AdditionalDependencies': [
« no previous file with comments | « test/win/winrt-app-type-revision/dllmain.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698