Inline the code dealing with entering spilled scopes and maintaining a...

Inline the code dealing with entering spilled scopes and maintaining a
spilled state.  Keep track of spilling only in debug builds.

[Erik Corry, 2009-05-13 10:57:48]

What does this do to the executable size on ARM?

[Erik Corry, 2009-05-14 09:15:10]

A lot of ifdefs and a lot of duplicated code for the different platforms :-(.

In src/codegen-inl.h can we have an object that takes care of
set_in_spilled_state with its constructor/destructor?  Then you can have an
empty implementation in debug mode.

LGTM I guess.

http://codereview.chromium.org/113259/diff/1/4
File src/ia32/codegen-ia32.h (right):

http://codereview.chromium.org/113259/diff/1/4#newcode619
Line 619: bool in_spilled_code_;
Is it really worth having this only in debug builds?  It adds a lot of ifdefs to
not always have this.

[Kevin Millikin (Chromium), 2009-05-14 10:24:36]

You're right, this is a mess.  It's a wishy-washy change: it doesn't make a
noticable performance difference on IA32 and it doesn't remove all overhead on
ARM.

I'm not going to commit it, and instead will try to do the right think on ARM
when I get a chance.