CRWSessionEntry: Replaced hardcoded strings with constants.

ios/web/navigation/crw_session_entry.h

Index: ios/web/navigation/crw_session_entry.h
diff --git a/ios/web/navigation/crw_session_entry.h b/ios/web/navigation/crw_session_entry.h
index 6c5f625d63112fb5b6825ddd8428c9297d8c766e..89e27aaf9a45eec75bd31fd76856e75c5e7a80b0 100644
--- a/ios/web/navigation/crw_session_entry.h
+++ b/ios/web/navigation/crw_session_entry.h
@@ -17,6 +17,40 @@ namespace web {
 class NavigationItem;
 class NavigationItemImpl;
 struct Referrer;
+
+// Keys used to serialize web::PageScrollState properties.
+extern NSString* const kPageScrollStateKey;
+extern NSString* const kScrollOffsetXKey;
+extern NSString* const kScrollOffsetYKey;
+extern NSString* const kMinimumZoomScaleKey;
+extern NSString* const kMaximumZoomScaleKey;
+extern NSString* const kZoomScaleKey;
+
+// Keys used to serialize navigation properties.
+
+// Current URL (std::string).
+extern NSString* const kURLKey;

[stuartmorgan, 2015/05/07 17:19:23]

These names are far too broad to be in the web namespace as-is; "URLKey" could
be lots of things across web. If these are going to be in anything other than an
anonymous namespace, they should be class-prefixed or similar.

[Eugene But (OOO till 7-30), 2015/05/07 17:43:12]

Done.

+// Current URL. Deprecated, used for backward compatibility (NSURL).
+extern NSString* const kURLDeperecatedKey;
+// Page referrer URL (std::string).
+extern NSString* const kReferrerURLKey;
+// Page referrer URL (NSURL). Deprecated, used for backward compatibility.
+extern NSString* const kReferrerURLDeprecatedKey;
+// Page referrer policy (Int).

[stuartmorgan, 2015/05/07 17:19:23]

Everywhere else you use an actual type name as it would be written in code;
please do the same here.

[Eugene But (OOO till 7-30), 2015/05/07 17:43:12]

Done.

+extern NSString* const kReferrerPolicyKey;
+// The time at which the last known local navigation has completed (Int64).
+extern NSString* const kTimestampKey;
+// Page title (NSString).
+extern NSString* const kTitleKey;
+// POST request data (NSData).
+extern NSString* const kPOSTDataKey;
+// HTTP request headers (NSDictionary).
+extern NSString* const kHTTPRequestHeadersKey;
+// Whether or not to bypass showing the resubmit data confirmation when loading
+// a POST request (BOOL).
+extern NSString* const kSkipResubmitConfirmationKey;
+// Should desctop user agent be used (BOOL)?

[stuartmorgan, 2015/05/07 17:19:23]

desktop

[Eugene But (OOO till 7-30), 2015/05/07 17:43:12]

Done.

+extern NSString* const kUseDesktopUserAgentKey;
 }
 
 // A CRWSessionEntry is similar to a NavigationEntry object in desktop Chrome.