CRWSessionEntry: Replaced hardcoded strings with constants.

ios/web/navigation/crw_session_entry.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_NAVIGATION_CRW_SESSION_ENTRY_H_
 #define IOS_WEB_NAVIGATION_CRW_SESSION_ENTRY_H_
 
 #import <Foundation/Foundation.h>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 
 namespace web {
 class NavigationItem;
 class NavigationItemImpl;
 struct Referrer;
+
+// Keys used to serialize web::PageScrollState properties.
+extern NSString* const kPageScrollStateKey;
+extern NSString* const kScrollOffsetXKey;
+extern NSString* const kScrollOffsetYKey;
+extern NSString* const kMinimumZoomScaleKey;
+extern NSString* const kMaximumZoomScaleKey;
+extern NSString* const kZoomScaleKey;
+
+// Keys used to serialize navigation properties.
+
+// Current URL (std::string).
+extern NSString* const kURLKey;

[stuartmorgan, 2015/05/07 17:19:23]

These names are far too broad to be in the web namespace as-is; "URLKey" could
be lots of things across web. If these are going to be in anything other than an
anonymous namespace, they should be class-prefixed or similar.

[Eugene But (OOO till 7-30), 2015/05/07 17:43:12]

Done.

+// Current URL. Deprecated, used for backward compatibility (NSURL).
+extern NSString* const kURLDeperecatedKey;
+// Page referrer URL (std::string).
+extern NSString* const kReferrerURLKey;
+// Page referrer URL (NSURL). Deprecated, used for backward compatibility.
+extern NSString* const kReferrerURLDeprecatedKey;
+// Page referrer policy (Int).

[stuartmorgan, 2015/05/07 17:19:23]

Everywhere else you use an actual type name as it would be written in code;
please do the same here.

[Eugene But (OOO till 7-30), 2015/05/07 17:43:12]

Done.

+extern NSString* const kReferrerPolicyKey;
+// The time at which the last known local navigation has completed (Int64).
+extern NSString* const kTimestampKey;
+// Page title (NSString).
+extern NSString* const kTitleKey;
+// POST request data (NSData).
+extern NSString* const kPOSTDataKey;
+// HTTP request headers (NSDictionary).
+extern NSString* const kHTTPRequestHeadersKey;
+// Whether or not to bypass showing the resubmit data confirmation when loading
+// a POST request (BOOL).
+extern NSString* const kSkipResubmitConfirmationKey;
+// Should desctop user agent be used (BOOL)?

[stuartmorgan, 2015/05/07 17:19:23]

desktop

[Eugene But (OOO till 7-30), 2015/05/07 17:43:12]

Done.

+extern NSString* const kUseDesktopUserAgentKey;
 }
 
 // A CRWSessionEntry is similar to a NavigationEntry object in desktop Chrome.
 // It maintains the information needed to save/restore a single entry in session
 // history (i.e., one site) for a tab. A tab may have multiple of these objects
 // comprising its entire session history.
 // TODO(rohitrao): Fold CRWSessionEntry's logic into NavigationItem.
 @interface CRWSessionEntry : NSObject<NSCoding, NSCopying>
 
 @property(nonatomic, readonly) const GURL& originalUrl;
 
 // Pointer to the NavigationItem associated with this CRWSessionEntry.
 // Eventually, this will replace CRWSessionEntry entirely.
 @property(nonatomic, readonly) web::NavigationItem* navigationItem;
 
 // Pointer to the NavigationItemImpl associated with this CRWSessionEntry.
 // TODO(kkhorimoto): This is a convenience property to avoid requiring static
 // casts every time the web layer needs access to members only available in
 // NavigationItemImpl.  Remove once more navigation management moves into
 // NavigationManager and CRWSessionEntry=>web::NavigationItemImpl conversions
 // become less prominent.
 @property(nonatomic, readonly) web::NavigationItemImpl* navigationItemImpl;
 
 // Initialize the session entry with the given NavigationItem.
 - (instancetype)initWithNavigationItem:(scoped_ptr<web::NavigationItem>)item;
 
 @end
 
 #endif  // IOS_WEB_NAVIGATION_CRW_SESSION_ENTRY_H_