CRWSessionEntry: Replaced hardcoded strings with constants.

CRWSessionEntry: Replaced hardcoded strings with constants.

BUG=228076
Committed: https://crrev.com/fad4bd3dc4f5a06c6c9bee17c9831c3278b30cbb
Cr-Commit-Position: refs/heads/master@{#329167}

[Eugene But (OOO till 7-30), 2015-05-07 16:45:55]

eugenebut@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[stuartmorgan, 2015-05-07 17:19:23]

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_entry.h (right):

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.h:32: extern NSString* const kURLKey;
These names are far too broad to be in the web namespace as-is; "URLKey" could
be lots of things across web. If these are going to be in anything other than an
anonymous namespace, they should be class-prefixed or similar.

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.h:39: // Page referrer policy (Int).
Everywhere else you use an actual type name as it would be written in code;
please do the same here.

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.h:52: // Should desctop user agent be used
(BOOL)?
desktop

[Eugene But (OOO till 7-30), 2015-05-07 17:43:13]

PTAL

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
File ios/web/navigation/crw_session_entry.h (right):

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.h:32: extern NSString* const kURLKey;
On 2015/05/07 17:19:23, stuartmorgan wrote:
> These names are far too broad to be in the web namespace as-is; "URLKey" could
> be lots of things across web. If these are going to be in anything other than
an
> anonymous namespace, they should be class-prefixed or similar.

Done.

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.h:39: // Page referrer policy (Int).
On 2015/05/07 17:19:23, stuartmorgan wrote:
> Everywhere else you use an actual type name as it would be written in code;
> please do the same here.

Done.

https://codereview.chromium.org/1132563002/diff/1/ios/web/navigation/crw_sess...
ios/web/navigation/crw_session_entry.h:52: // Should desctop user agent be used
(BOOL)?
On 2015/05/07 17:19:23, stuartmorgan wrote:
> desktop

Done.

[stuartmorgan, 2015-05-10 21:46:16]

LGTM. I sort of feel like this would be better in a +protected header rather
than exposed here, but I'm fine either way.

https://codereview.chromium.org/1132563002/diff/20001/ios/web/navigation/crw_...
File ios/web/navigation/crw_session_entry.h (right):

https://codereview.chromium.org/1132563002/diff/20001/ios/web/navigation/crw_...
ios/web/navigation/crw_session_entry.h:41: // The time at which the last known
local navigation has completed (Int64).
s/Int/int/

[Eugene But (OOO till 7-30), 2015-05-11 16:54:15]

>> I sort of feel like this would be better in a +protected header rather than
exposed here, but I'm fine either way.
crw_session_entry.h is not a public header, so I would prefer to keep things
simple and avoid adding protected header.

https://codereview.chromium.org/1132563002/diff/20001/ios/web/navigation/crw_...
File ios/web/navigation/crw_session_entry.h (right):

https://codereview.chromium.org/1132563002/diff/20001/ios/web/navigation/crw_...
ios/web/navigation/crw_session_entry.h:41: // The time at which the last known
local navigation has completed (Int64).
On 2015/05/10 21:46:16, stuartmorgan wrote:
> s/Int/int/

Changed to int64_t

[Eugene But (OOO till 7-30), 2015-05-11 16:54:19]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-05-11 16:54:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
stuartmorgan@chromium.org
Link to the patchset: https://codereview.chromium.org/1132563002/#ps40001
(title: "Updated comments")

[commit-bot: I haz the power, 2015-05-11 16:56:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132563002/40001

[commit-bot: I haz the power, 2015-05-11 17:16:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-11 17:18:23]

Patchset 3 (id:??) landed as
https://crrev.com/fad4bd3dc4f5a06c6c9bee17c9831c3278b30cbb
Cr-Commit-Position: refs/heads/master@{#329167}