Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 113254: Change our mixed content strings to be more technically accurate. (Closed)

Created:
11 years, 7 months ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change our mixed content strings to be more technically accurate. The page can have mixed content without having any insecure *elements*, per se. R=wtc TEST=Go to https://webblaze.org/abarth/tests/mixed-content/ and point at the yellow triangle in the omnibox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15937

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
11 years, 7 months ago (2009-05-12 06:22:36 UTC) #1
abarth-chromium
11 years, 7 months ago (2009-05-12 06:22:41 UTC) #2
wtc
11 years, 7 months ago (2009-05-12 18:13:43 UTC) #3
LGTM.

Please add a TEST= item to the CL's description to tell QA
how to verify the change.

I guess "content" is more correct than "elements" because
not all content is HTML elements?

Powered by Google App Engine
This is Rietveld 408576698