Catch Exception for Intent.parseUri instead of URISyntaxException

Catch Exception for Intent.parseUri instead of URISyntaxException

Intent.parseUri can throw other excpetions like NumberFormatException.
So we need to catch Exception to avoid crash.

BUG=484336
Committed: https://crrev.com/e9785bb71f9e0b8a9a3ba321c2c6483c8805e5a1
Cr-Commit-Position: refs/heads/master@{#329163}

[Jaekyun Seok (inactive), 2015-05-08 01:47:39]

jaekyun@chromium.org changed reviewers:
+ tedchoc@chromium.org, torne@chromium.org

[Jaekyun Seok (inactive), 2015-05-08 01:47:40]

torne@chromium.org: Please review changes in
android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java.

tedchoc@chromium.org: Please review changes in chrome/* and content/*.

[Ted C, 2015-05-08 17:40:25]

lgtm

https://codereview.chromium.org/1132473004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1132473004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:80:
Log.w(TAG, "Bad URI " + params.getUrl() + ": " + ex.getMessage());
same thing here I mentioned downstream.   Do ", ex);" instead of just the
message.

https://codereview.chromium.org/1132473004/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
(right):

https://codereview.chromium.org/1132473004/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java:147:
Log.w(TAG, "Bad URI " + intentUrl + ": " + ex.getMessage());
here too :-)

[Jaekyun Seok (inactive), 2015-05-10 06:48:00]

https://codereview.chromium.org/1132473004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/1132473004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:80:
Log.w(TAG, "Bad URI " + params.getUrl() + ": " + ex.getMessage());
On 2015/05/08 17:40:25, Ted C wrote:
> same thing here I mentioned downstream.   Do ", ex);" instead of just the
> message.

Done.

https://codereview.chromium.org/1132473004/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
(right):

https://codereview.chromium.org/1132473004/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java:147:
Log.w(TAG, "Bad URI " + intentUrl + ": " + ex.getMessage());
On 2015/05/08 17:40:25, Ted C wrote:
> here too :-)

Done.

[Torne, 2015-05-11 10:15:59]

lgtm

[Jaekyun Seok (inactive), 2015-05-11 16:00:38]

The CQ bit was checked by jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-05-11 16:00:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1132473004/#ps20001
(title: "Apply Ted's comments")

[commit-bot: I haz the power, 2015-05-11 16:01:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132473004/20001

[commit-bot: I haz the power, 2015-05-11 16:58:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-11 17:00:19]

Patchset 2 (id:??) landed as
https://crrev.com/e9785bb71f9e0b8a9a3ba321c2c6483c8805e5a1
Cr-Commit-Position: refs/heads/master@{#329163}

[jbudorick, 2015-05-11 17:19:41]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1139753003/ by jbudorick@chromium.org.

The reason for reverting is: broke findbugs:
http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder...

slipped through CQ because analyze in android_clang_dbg_recipe decided it didn't
need to compile:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d....

[jbudorick, 2015-05-11 17:23:36]

On 2015/05/11 17:19:41, jbudorick wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1139753003/ by mailto:jbudorick@chromium.org.
> 
> The reason for reverting is: broke findbugs:
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder...
> 
> slipped through CQ because analyze in android_clang_dbg_recipe decided it
didn't
> need to compile:
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d....

filed bug against analyze:
https://code.google.com/p/chromium/issues/detail?id=486801