chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java - Issue 1132473004: Catch Exception for Intent.parseUri instead of URISyntaxException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java

Issue 1132473004: Catch Exception for Intent.parseUri instead of URISyntaxException (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply Ted's comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java

index 0972aeec2b732750710d9d0fbc1b14cae0e8e782..151113cb31277782508725a30c35c68410733987 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java

@@ -27,8 +27,6 @@ import org.chromium.chrome.R;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.browser.WebContentsObserver;

-import java.net.URISyntaxException;

/**

* Java side of Android implementation of the website settings UI.

@@ -212,7 +210,7 @@ public class ConnectionInfoPopup implements OnClickListener {

i.putExtra(Browser.EXTRA_CREATE_NEW_TAB, true);

i.putExtra(Browser.EXTRA_APPLICATION_ID, mContext.getPackageName());

mContext.startActivity(i);

- } catch (URISyntaxException ex) {

+ } catch (Exception ex) {

// Do nothing intentionally.

}