Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1132373003: Add function for logging blend info on XP. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add function for logging blend info on XP. Committed: https://skia.googlesource.com/skia/+/f7cc87719e53df86784d0d953b88c45a3be38953

Patch Set 1 #

Patch Set 2 : remove -1s and cnts from enum values #

Patch Set 3 : fix warning? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -21 lines) Patch
M include/gpu/GrXferProcessor.h View 1 5 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 chunk +94 lines, -0 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 4 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
bsalomon
5 years, 7 months ago (2015-05-11 15:33:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132373003/1
5 years, 7 months ago (2015-05-11 15:33:22 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-11 15:33:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/971) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 7 months ago (2015-05-11 15:34:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132373003/20001
5 years, 7 months ago (2015-05-11 15:47:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/973)
5 years, 7 months ago (2015-05-11 15:48:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132373003/40001
5 years, 7 months ago (2015-05-11 16:19:25 UTC) #13
egdaniel
lgtm
5 years, 7 months ago (2015-05-11 17:43:51 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:21:20 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f7cc87719e53df86784d0d953b88c45a3be38953

Powered by Google App Engine
This is Rietveld 408576698