Issue 1132343003: Passing scoped_ptr into ScopedVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1132343003: Passing scoped_ptr into ScopedVector (Closed)

Created:
5 years, 7 months ago by Pranay

Modified:
5 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in sync/ BUG=457697 Committed: https://crrev.com/f1b03ed8cf3a881b36a33f46d22c181ba37637b1 Cr-Commit-Position: refs/heads/master@{#329619}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sync/internal_api/protocol_event_buffer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sync/sessions/model_type_registry.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132343003/1

5 years, 7 months ago (2015-05-13 12:08:34 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 12:52:20 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f1b03ed8cf3a881b36a33f46d22c181ba37637b1
Cr-Commit-Position: refs/heads/master@{#329619}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages