sync/sessions/model_type_registry.cc - Issue 1132343003: Passing scoped_ptr into ScopedVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/sessions/model_type_registry.cc

Issue 1132343003: Passing scoped_ptr into ScopedVector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/sessions/model_type_registry.cc

diff --git a/sync/sessions/model_type_registry.cc b/sync/sessions/model_type_registry.cc

index 2366f205660c565079c4f66ac287aee0a6811f6a..729727e0a73dabcc0a21521d65d67cec7252306b 100644

--- a/sync/sessions/model_type_registry.cc

+++ b/sync/sessions/model_type_registry.cc

@@ -225,7 +225,7 @@ void ModelTypeRegistry::ConnectSyncTypeToWorker(

commit_contributor_map_.insert(std::make_pair(type, worker.get()));

// The container takes ownership.

- model_type_sync_workers_.push_back(worker.release());

+ model_type_sync_workers_.push_back(worker.Pass());

DCHECK(Intersection(GetEnabledDirectoryTypes(),

GetEnabledNonBlockingTypes()).Empty());

« no previous file with comments | « sync/internal_api/protocol_event_buffer.cc ('k') | no next file » | no next file with comments »