Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1132243004: IDL: Determine maximum distinguishing argument index runtime, if needed (Closed)

Created:
5 years, 7 months ago by Jens Widell
Modified:
5 years, 7 months ago
Reviewers:
haraken, philipj_slow
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Determine maximum distinguishing argument index runtime, if needed If an overloaded method is partially runtime enabled such that its "longest" overload(s) might be disabled, we need to determine the maximum distinguishing argument index runtime, to avoid using an index for which all actual overloads are disabled, since that would typically cause us to incorrectly reject the call as not matching any overload. The implementation is largely a copy of the existing and very similar runtime determination of the correct Function.length value. While we're at it, drop the overloads['minarg'] value, which was just a less accurate variant of overloads['length'] used in a few places where it didn't really matter anyway. BUG=486249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195251

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -40 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 3 chunks +56 lines, -31 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
haraken@: PTAL philipj@: FYI
5 years, 7 months ago (2015-05-12 09:29:28 UTC) #2
philipj_slow
Nice, the generated code looks good to me at least.
5 years, 7 months ago (2015-05-12 10:02:12 UTC) #3
haraken
LGTM
5 years, 7 months ago (2015-05-12 11:53:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1132243004/20001
5 years, 7 months ago (2015-05-12 11:58:47 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:57:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195251

Powered by Google App Engine
This is Rietveld 408576698