Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 1132243004: IDL: Determine maximum distinguishing argument index runtime, if needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/idls/core/TestObject.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index f63c649fcbf15831d1062b5ff1a51f9c9b4a66dc..3d18b85c0b5149ccb74513b8cd526ce25d53ec89 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -11252,11 +11252,11 @@ static void partiallyRuntimeEnabledOverloadedVoidMethod1Method(const v8::Functio
static void partiallyRuntimeEnabledOverloadedVoidMethod2Method(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObject* impl = V8TestObject::toImpl(info.Holder());
- TestInterfaceImplementation* testInterface;
+ TestInterfaceImplementation* testInterfaceArg;
{
- testInterface = V8TestInterface::toImplWithTypeCheck(info.GetIsolate(), info[0]);
+ testInterfaceArg = V8TestInterface::toImplWithTypeCheck(info.GetIsolate(), info[0]);
}
- impl->partiallyRuntimeEnabledOverloadedVoidMethod(testInterface);
+ impl->partiallyRuntimeEnabledOverloadedVoidMethod(testInterfaceArg);
}
static void partiallyRuntimeEnabledOverloadedVoidMethod3Method(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ -11276,6 +11276,25 @@ static void partiallyRuntimeEnabledOverloadedVoidMethod3Method(const v8::Functio
impl->partiallyRuntimeEnabledOverloadedVoidMethod(longArg, stringArg);
}
+static void partiallyRuntimeEnabledOverloadedVoidMethod4Method(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+ ExceptionState exceptionState(ExceptionState::ExecutionContext, "partiallyRuntimeEnabledOverloadedVoidMethod", "TestObject", info.Holder(), info.GetIsolate());
+ TestObject* impl = V8TestObject::toImpl(info.Holder());
+ int longArg;
+ V8StringResource<> stringArg;
+ TestInterfaceImplementation* testInterfaceArg;
+ {
+ longArg = toInt32(info.GetIsolate(), info[0], NormalConversion, exceptionState);
+ if (exceptionState.throwIfNeeded())
+ return;
+ stringArg = info[1];
+ if (!stringArg.prepare())
+ return;
+ testInterfaceArg = V8TestInterface::toImplWithTypeCheck(info.GetIsolate(), info[2]);
+ }
+ impl->partiallyRuntimeEnabledOverloadedVoidMethod(longArg, stringArg, testInterfaceArg);
+}
+
static int partiallyRuntimeEnabledOverloadedVoidMethodMethodLength()
{
if (RuntimeEnabledFeatures::featureName1Enabled()) {
@@ -11287,10 +11306,18 @@ static int partiallyRuntimeEnabledOverloadedVoidMethodMethodLength()
return 2;
}
+static int partiallyRuntimeEnabledOverloadedVoidMethodMethodMaxArg()
+{
+ if (RuntimeEnabledFeatures::featureName3Enabled()) {
+ return 3;
+ }
+ return 2;
+}
+
static void partiallyRuntimeEnabledOverloadedVoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "partiallyRuntimeEnabledOverloadedVoidMethod", "TestObject", info.Holder(), info.GetIsolate());
- switch (std::min(2, info.Length())) {
+ switch (std::min(TestObjectV8Internal::partiallyRuntimeEnabledOverloadedVoidMethodMethodMaxArg(), info.Length())) {
case 1:
if (RuntimeEnabledFeatures::featureName2Enabled()) {
if (V8TestInterface::hasInstance(info[0], info.GetIsolate())) {
@@ -11311,6 +11338,14 @@ static void partiallyRuntimeEnabledOverloadedVoidMethodMethod(const v8::Function
return;
}
break;
+ case 3:
+ if (RuntimeEnabledFeatures::featureName3Enabled()) {
+ if (true) {
+ partiallyRuntimeEnabledOverloadedVoidMethod4Method(info);
+ return;
+ }
+ }
+ break;
default:
break;
}
« no previous file with comments | « Source/bindings/tests/idls/core/TestObject.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698